Skip to content

Don't enqueue submission job after fixing missing filenames #2011

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lfdebrux wants to merge 1 commit into
base: main
Choose a base branch
from
+5 −7
Open

Don't enqueue submission job after fixing missing filenames #2011

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions lib/tasks/submissions.rake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -254,6 +254,8 @@ namespace :submissions do
submission.answers.each_pair do |question_id, answer|
next unless answer.include?("original_filename") && answer["original_filename"].blank? && answer["uploaded_file_key"].present?

Rails.logger.info "Updating blank original_filename for answer to question #{question_id} in submission with reference #{submission.reference}"

question = submission.form.page_by_id(question_id)
extension = ::File.extname(answer["uploaded_file_key"])
filename = "#{question.position}-#{question.question_text.parameterize}#{extension}"
Expand All @@ -263,8 +265,9 @@ namespace :submissions do
submission.save!

if submission.answers_previously_changed?
Rails.logger.info "Re-delivering submission with reference #{submission.reference}"
SendSubmissionJob.perform_later(submission)
Rails.logger.info "Submission for reference #{submission.reference} has been updated, retry submission with jobs:retry_failed"
else
Rails.logger.info "No filenames missing, nothing to do"
end
end
end
Expand Down
5 changes: 0 additions & 5 deletions spec/lib/tasks/submissions.rake_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -775,11 +775,6 @@
"original_filename" => "1-upload-your-evidence.jpg",
)
end

it "reschedules the submission" do
task.invoke(submission.reference)
expect(SendSubmissionJob).to have_been_enqueued
end
end

context "when original filename is present" do
Expand Down
Loading