Skip to content

[DO NOT MERGE] Use JavaScript enhanced file upload component #2009

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
stephencdaly wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

[DO NOT MERGE] Use JavaScript enhanced file upload component #2009

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5a86c69
NEEDS TRANSLATION - Use JavaScript enhanced file upload component
stephencdaly Mar 31, 2026
d7eb921
Make feature test work with enhanced file upload component
stephencdaly Mar 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion app/components/question/file_component/view.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,5 +7,11 @@
text: question.hint_text,
class: "govuk-!-margin-bottom-7"
},
accept: Question::File::FILE_TYPES.join(", ")
choose_files_button_text: t("govuk_design_system_formbuilder.govuk_file_field.choose_files_button_text"),
drop_instruction_text: t("govuk_design_system_formbuilder.govuk_file_field.drop_instruction_text"),
no_file_chosen_text: t("govuk_design_system_formbuilder.govuk_file_field.no_file_chosen_text"),
entered_drop_zone_text: t("govuk_design_system_formbuilder.govuk_file_field.entered_drop_zone_text"),
left_drop_zone_text: t("govuk_design_system_formbuilder.govuk_file_field.left_drop_zone_text"),
accept: Question::File::FILE_TYPES.join(", "),
javascript: true
%>
7 changes: 7 additions & 0 deletions config/locales/cy.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -412,6 +412,13 @@ cy:
govuk_components:
govuk_summary_list:
change: Newid
govuk_design_system_formbuilder:
govuk_file_field:
choose_files_button_text: Dewiswch ffeil
drop_instruction_text: neu ollwng ffeil
entered_drop_zone_text: Wedi mynd i mewn i'r parth gollwng
left_drop_zone_text: Parth gollwng i'r chwith
no_file_chosen_text: Dim ffeil wedi'i dewis
helpers:
error:
message_prefix: Gwall
Expand Down
7 changes: 7 additions & 0 deletions config/locales/en.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -412,6 +412,13 @@ en:
govuk_components:
govuk_summary_list:
change: Change
govuk_design_system_formbuilder:
govuk_file_field:
choose_files_button_text: Choose file
drop_instruction_text: or drop file
entered_drop_zone_text: Entered drop zone
left_drop_zone_text: Left drop zone
no_file_chosen_text: No file chosen
helpers:
error:
message_prefix: Error
Expand Down
7 changes: 4 additions & 3 deletions spec/features/fill_in_file_upload_question_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,11 +116,12 @@ def then_i_should_see_the_first_question
end

def then_i_see_the_file_upload_component
expect(page).to have_css("input[type=file]")
expect(page).to have_css("input[type=file]", visible: :hidden)
expect(page).to have_css("[data-module='govuk-file-upload']")
end

def when_i_upload_a_file
attach_file question_text, test_file
attach_file test_file, make_visible: true
end

def and_i_click_on_continue
Expand Down Expand Up @@ -177,6 +178,6 @@ def and_an_email_submission_should_have_been_sent

def then_i_see_an_error_message_that_the_file_contains_a_virus
expect(page.find(".govuk-error-summary")).to have_text "The selected file contains a virus"
expect(page).to have_css("input[type=file]")
expect(page).to have_css("input[type=file]", visible: :hidden)
end
end
Loading