Draft
Conversation
Bumps [sentry-rails](https://github.com/getsentry/sentry-ruby) from 5.28.0 to 6.1.0. - [Release notes](https://github.com/getsentry/sentry-ruby/releases) - [Changelog](https://github.com/getsentry/sentry-ruby/blob/master/CHANGELOG.md) - [Commits](getsentry/sentry-ruby@5.28.0...6.1.0) --- updated-dependencies: - dependency-name: sentry-rails dependency-version: 6.1.0 dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
config.enable_tracing has been removed in favour of config.traces_sample_rate, which has a default value of nil Sentry::Event#to_hash has been replaced by to_h Returning a hash from before_send is no longer supported and will drop the event. Instead, we need to individually apply the filters to the places where PII could get in as per https://docs.sentry.io/platforms/ruby/guides/rails/configuration/filtering/#using-before-send We also need to filter the breadcrumbs using config.before_breadcrumb. Don't attempt to filter emails from exception messages, as this is not straightforward and doesn't seem likely to happen unless we put emails in exception messages.
|
🎉 A review copy of this PR has been deployed! You can reach it at: https://pr-956.www.review.forms.service.gov.uk/ It may take 5 minutes or so for the application to be fully deployed and working. If it still isn't ready For the sign in details and more information, see the review apps wiki page. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this pull request solve?
Trello card:
config.enable_tracing has been removed in favour of
config.traces_sample_rate, which has a default value of nil
Sentry::Event#to_hash has been replaced by to_h
Returning a hash from before_send is no longer supported and will drop the event. Instead, we need to individually apply the filters to the places where PII could get in as per https://docs.sentry.io/platforms/ruby/guides/rails/configuration/filtering/#using-before-send
We also need to filter the breadcrumbs using config.before_breadcrumb.
This PR doesn't currently attempt to apply the data scrubbing filter to exception messages, we need to find a way to do this as some exception messages can pull in PII, such as a NoMethodError https://trello.com/c/PuVK5TWl/1346-sentry-alert-forms-runner-undefined-method-strip-for-array
Things to consider when reviewing