Merged
Conversation
Bumps [govuk_markdown][https://github.com/DFE-Digital/govuk-markdown] from 2.0.3 to 2.0.4. - [Release notes](https://github.com/DFE-Digital/govuk-markdown/releases/tag/v2.0.4) - [Commits](DFE-Digital/govuk-markdown@v2.0.3...v2.0.4) We require 2.0.4 in the Gemfile because we want to use the mixin feature added in this release.
Instead of ApplicationMarkdown inheriting from GovukMarkdown::Renderer and reimplementing the interface expected by markdown-rails (which is not the expected way of using that gem), make ApplicationMarkdown look more like the template file from markdown-rails and mixin the govuk-markdown functionality. This makes our code much simpler, and it easier to manage updates of the `markdown_rails` gem.
|
🎉 A review copy of this PR has been deployed! You can reach it at: https://pr-1120.www.review.forms.service.gov.uk/ It may take 5 minutes or so for the application to be fully deployed and working. If it still isn't ready For the sign in details and more information, see the review apps wiki page. |
theseanything
approved these changes
Apr 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this pull request solve?
Instead of ApplicationMarkdown inheriting from GovukMarkdown::Renderer and reimplementing the interface expected by markdown-rails (which is not the expected way of using that gem), make ApplicationMarkdown look more like the template file from markdown-rails and mixin the govuk-markdown functionality.
This makes our code much simpler, and it easier to manage updates of the
markdown_railsgem.Things to consider when reviewing