Open
Conversation
lfdebrux
added
dependencies
lfdebrux
force-pushed
the
ldeb-bump-vite_ruby
branch
from
8d0fc9e to
ebf4328
Compare
Bumps [vite_ruby](https://github.com/ElMassimo/vite_ruby) from 3.9.3 to 3.10.0. - [Changelog](https://github.com/ElMassimo/vite_ruby/blob/vite_ruby@3.10.0/vite_ruby/CHANGELOG.md) - [Commits](https://github.com/ElMassimo/vite_ruby/compare/vite_ruby@3.9.3...vite_ruby@3.10.0) --- updated-dependencies: - dependency-name: vite_ruby dependency-version: 3.10.0 dependency-type: indirect update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [vite_rails](https://github.com/ElMassimo/vite_ruby) from 3.0.20 to 3.10.0. - [Changelog](https://github.com/ElMassimo/vite_ruby/blob/vite_rails@3.10.0/vite_rails/CHANGELOG.md) - [Commits](https://github.com/ElMassimo/vite_ruby/compare/vite_rails@3.0.20...vite_rails@3.10.0) --- updated-dependencies: - dependency-name: vite_rails dependency-version: 3.10.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [vite-plugin-ruby](https://github.com/ElMassimo/vite_ruby) from 5.1.3 to 5.2.0. - [Commits](https://github.com/ElMassimo/vite_ruby/compare/vite-plugin-ruby@5.1.3...vite-plugin-ruby@5.2.0) --- updated-dependencies: - dependency-name: vite-plugin-ruby dependency-version: 5.2.0 dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
The `vite_ruby` and `vite_rails` gems depend on each other, and they often have new versions released at the same time, so it would be helpful to group their dependency bumps together.
lfdebrux
force-pushed
the
ldeb-bump-vite_ruby
branch
from
ebf4328 to
3281906
Compare
|
🎉 A review copy of this PR has been deployed! You can reach it at: https://pr-2664.admin.review.forms.service.gov.uk/ It may take 5 minutes or so for the application to be fully deployed and working. If it still isn't ready For the sign in details and more information, see the review apps wiki page. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this pull request solve?
This PR rolls a bunch of Dependabot PRs bumping packages for Vite Ruby into one, as they need to be bumped together.
This PR also adds a Dependabot group to try and make it work better in future... I'm not hopeful though as Dependabot doesn't seem to have groups across package ecosystems (see https://docs.github.com/en/code-security/tutorials/secure-your-dependencies/optimizing-pr-creation-version-updates#grouping-related-dependencies-together), so it's only possible to have a group for
vite_rubyandvite_rails, which are both Ruby gems, but they can't also be in a group withvite-plugin-ruby, which is an NPM package.Things to consider when reviewing