(via govambam): Add stale handler guard to ws.onclose in lspClient.ts#5
Merged
macroscopeapp[bot] merged 1 commit intoreview-pr-1263from Feb 6, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Macroscope: Fix It For Me
Activity
Currently: Auto-merged f2faa21
Previously
Add stale WebSocket guard to
ws.oncloseto avoid resolvingclientReadyPromiseor stoppinglanguageClientinlspClient.tsAdd an early return in
initWebSocketAndStartClientws.onclosethat checkswebSocket === wsbefore resolvingclientReadyPromiseand stopping/clearinglanguageClientin lspClient.ts.📍Where to Start
Start in
initWebSocketAndStartClientat thews.onclosehandler in lspClient.ts.Macroscope summarized cc68ac0.