Skip to content

Conversation

@robskrob
Copy link

I do not think I implemented the macros and shared example exercises correctly. Moreover, I have the following failed tests which I believe is representative of my poor implementation:

  1. QueueItemsController POST create creates the queue item that is associated with the signed in user
    Failure/Error: expect(QueueItem.first.user).to eq(current_user)
   expected: #<User id: 2, email: "stan@nicolas.biz", password_digest: "$2a$04$j4Ql0T92N9gxdtk37ze2ZuOyYe3FJQJ5cAZTpa8vAhm5...", full_name: "Sienna Russel", created_at: "2014-03-27 12:32:57", updated_at: "2014-03-27 12:32:57">
        got: #<User id: 1, email: "litzy.turner@mosciski.net", password_digest: "$2a$04$OkKJ7yBJ0GFc9JuZzbjU7.izQsTqEobS1EOOGbbVF.5F...", full_name: "Loren Huel", created_at: "2014-03-27 12:32:57", updated_at: "2014-03-27 12:32:57">

   (compared using ==)

   Diff:
   @@ -1,2 +1,2 @@
   -#<User id: 2, email: "stan@nicolas.biz", password_digest: "$2a$04$j4Ql0T92N9gxdtk37ze2ZuOyYe3FJQJ5cAZTpa8vAhm5...", full_name: "Sienna Russel", created_at: "2014-03-27 12:32:57", updated_at: "2014-03-27 12:32:57">
   +#<User id: 1, email: "litzy.turner@mosciski.net", password_digest: "$2a$04$OkKJ7yBJ0GFc9JuZzbjU7.izQsTqEobS1EOOGbbVF.5F...", full_name: "Loren Huel", created_at: "2014-03-27 12:32:57", updated_at: "2014-03-27 12:32:57">

If the reviewer would not mind, it would be great if he or she could pay particular attention to the test suites: reviews and queue_items controller.

Everything else is more or less similar to how kevin implements with some deviations here and there.

Rob Jewell added 30 commits March 15, 2014 19:11
…ntax in queue_item model, replaces flash.now.alert with flash[:notice in sessions controller]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants