-
Notifications
You must be signed in to change notification settings - Fork 111
Mod 3 week 3 #75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
robskrob
wants to merge
134
commits into
gotealeaf:master
Choose a base branch
from
robskrob:mod_3_week_3
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Mod 3 week 3 #75
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fter numerous attempts to add more
…fter numerous attempts to add more
…ms and for destroying a queue item
…ntax in queue_item model, replaces flash.now.alert with flash[:notice in sessions controller]
… and shared examples
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I do not think I implemented the macros and shared example exercises correctly. Moreover, I have the following failed tests which I believe is representative of my poor implementation:
Failure/Error: expect(QueueItem.first.user).to eq(current_user)
If the reviewer would not mind, it would be great if he or she could pay particular attention to the test suites: reviews and queue_items controller.
Everything else is more or less similar to how kevin implements with some deviations here and there.