Skip to content

Conversation

@zhenghaoz
Copy link
Contributor

No description provided.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR refactors the test infrastructure to use the ml-100k dataset instead of Redis-backed mock data for integration testing. The changes simplify the development and CI setup by replacing Docker Compose with a shell script that sets up a pre-configured Gorse instance with real movie recommendation data.

  • Migrated tests from synthetic data to ml-100k dataset validation
  • Added delete_feedback API methods to both sync and async clients
  • Removed Redis dependency and simplified infrastructure setup
  • Version bumped to 0.5.0

Reviewed changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
tests/test_gorse.py Refactored all tests to validate against ml-100k dataset instead of creating mock data; added UTC import for proper timezone handling; removed Redis dependency
gorse/init.py Added delete_feedback methods to both sync and async clients for deleting feedback entries
test-requirements.txt Removed redis dependency
setup.py Version bumped from 0.4.10 to 0.5.0
docker-compose.yml Removed entire Docker Compose configuration
config.toml Removed Gorse configuration file
CONTRIBUTING.md Updated setup instructions to use new shell script instead of Docker Compose
.github/workflows/ci.yml Replaced Docker Compose health check with shell script setup
.devcontainer/devcontainer.json Added new Dev Container configuration
.devcontainer/Dockerfile Added Dev Container Dockerfile

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Removed Python 3.10 from the CI workflow matrix.
@zhenghaoz zhenghaoz merged commit 513d61b into main Nov 23, 2025
4 checks passed
@zhenghaoz zhenghaoz deleted the new branch November 23, 2025 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant