Skip to content

Conversation

Copy link

Copilot AI commented Oct 13, 2025

Summary

This PR removes the deprecated Subscribe field from User test data in the PyGorse test suite, as requested in issue #[issue_number].

Changes

The Subscribe field has been removed from all user creation test data in both synchronous and asynchronous test cases:

Before:

client.insert_user({'UserId': '100', 'Labels': ['a', 'b', 'c'], 'Subscribe': ['d', 'e'], 'Comment': 'comment'})

After:

client.insert_user({'UserId': '100', 'Labels': ['a', 'b', 'c'], 'Comment': 'comment'})

Test Expectations

While the client no longer sends the Subscribe field, the Gorse API backend still returns 'Subscribe': None in responses (as the field exists in the backend schema but is deprecated). Test assertions have been updated accordingly to expect this behavior.

Testing

  • ✅ All 12 tests pass successfully
  • ✅ Both sync (TestGorseClient) and async (TestAsyncGorseClient) user tests validated
  • ✅ No other tests affected by the changes

Impact

This change ensures the PyGorse client library tests align with the deprecation of the Subscribe field while maintaining compatibility with the current Gorse API behavior.

Original prompt

This section details on the original issue you should resolve

<issue_title>remove Subscribe from User</issue_title>
<issue_description>Remove Subscribe struct from User and its tests.</issue_description>

Comments on the Issue (you are @copilot in this section)

Fixes #7


💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.

@zhenghaoz zhenghaoz marked this pull request as ready for review October 13, 2025 12:45
Co-authored-by: zhenghaoz <9030120+zhenghaoz@users.noreply.github.com>
Copilot AI changed the title [WIP] Remove Subscribe struct from User and its tests Remove Subscribe field from User test data Oct 13, 2025
Copilot AI requested a review from zhenghaoz October 13, 2025 12:51
@zhenghaoz zhenghaoz closed this Nov 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

remove Subscribe from User

2 participants