Support setting per-role config with ALTER ROLE SET#4
Conversation
PLTSR-1003 Patch pgbedrock to support ALTER ROLES SET
This way we can use it to set per-role parameters like timeout. |
|
I still need to make sure this works as expected on staging. |
fd0088f to
3b27a95
Compare
|
So this was successfully tested on staging. Here are the logs from pgbedrock: And how the settings have been changed (from |
|
I created gorgias/gorgias#12995 if you want to see the change in the config. |
FlipEnergy
left a comment
There was a problem hiding this comment.
This is good work, Johan. LGTM.
3b27a95 to
8316248
Compare
|
@FlipEnergy I just imported your commit from the upstream PR. |
deadlytea
left a comment
There was a problem hiding this comment.
Would be nice to have some tests for the byte/duration parse logic before we put this in, also I'm not a fan of configs as the wording choice as it makes me think of a set of config structures, not a set of parameters, but I won't block on that we can update if we can think of something better
8316248 to
2531cda
Compare
Done and it helped me find some bugs, I should’ve done that earlier. |
Upstream PR: Squarespace/pgbedrock#73