chore: optimize tests

[hwbrzzl]

📑 Description

Optimize Path Handling in Template Tests

Summary

This PR optimizes the test files by replacing the path.Resource abstraction with explicit filepath.Join calls for constructing resource paths. The changes also improve test cleanup by introducing deferred cleanup functions to ensure temporary test artifacts are properly removed.

Main features:

1. Path Handling Standardization

• Replaces path.Resource usage with explicit filepath.Join("resources", "views", ...) constructs
• Adds path/filepath import and removes github.com/goravel/framework/support/path import
• Makes resource path handling more explicit and maintainable

Example change:

// Before
path.Resource("views/index.html")

// After
filepath.Join("resources", "views", "index.html")

2. Improved Test Cleanup

• Introduces deferred cleanup functions in test cases to remove the "resources" directory after execution
• Ensures test artifacts don't persist between test runs
• Centralizes cleanup logic using defer statements

Example pattern:

defer func() {
    assert.Nil(t, file.Remove("resources"))
}()

3. Test Structure Enhancements

• Maintains existing test flow and assertions while adjusting file path handling
• Consolidates cleanup operations from multiple points to single deferred functions
• No changes to test logic or expected behavior

Impact

• Lines changed: +21/-15 total across both test files
• Code review effort: Medium
• Behavior: No functional changes; improves code clarity and test artifact management

✅ Checks

• Added test cases for my code

[coderabbitai]

📝 Walkthrough

Walkthrough

Two test files are refactored to replace a custom path abstraction (path.Resource) with standard filepath.Join constructs. Import statements are updated to use path/filepath instead of the framework's path support package. Deferred cleanup is introduced for test resource directories.

Changes

Cohort / File(s)	Summary
Test file path refactoring template_test.go, view_test.go	Replace path.Resource usage with explicit filepath.Join("resources", "views", ...) constructs; update imports from github.com/goravel/framework/support/path to path/filepath; introduce deferred directory cleanup in tests for resource directories

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

🚥 Pre-merge checks | ✅ 1 | ❌ 2

❌ Failed checks (1 warning, 1 inconclusive)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.
Title check	❓ Inconclusive	The title 'chore: optimize tests' is vague and generic. While it mentions tests, it doesn't specify what optimization was performed or describe the actual changes made (replacing path.Resource with filepath.Join in test files).	Consider a more descriptive title like 'chore: replace path.Resource with filepath.Join in tests' to clarify the specific optimization being made.

✅ Passed checks (1 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch bowen/optimize-tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}