chore: optimize tests

[hwbrzzl]

📑 Description

Test Structure Optimization

This PR optimizes the test structure in view_test.go by replacing custom path utilities with standard library functions and improving test cleanup patterns.

Main Changes

Import Updates:

• Added "path/filepath" from the Go standard library
• Removed "github.com/goravel/framework/support/path" dependency

Path Resolution Refactoring:

• Replaced path.Resource("views", "...") calls with filepath.Join("resources", "views", "...") across three test functions (TestView_Make, TestView_First, TestView_CSRFToken)
• This makes the path construction more explicit and removes a custom framework dependency

Test Cleanup Improvements:

• Migrated resource cleanup from the end of test functions to deferred cleanup blocks at the beginning of each test
• Changed from:

  // cleanup at end
  assert.Nil(t, file.Remove("resources"))

  to:

  // cleanup at start via defer
  defer func() {
      assert.Nil(t, file.Remove("resources"))
  }()

• This ensures cleanup executes even if a test panics, improving test reliability

Impact

• Lines changed: +18/-12
• Test coverage: No changes to test logic or assertions, only structural improvements
• Benefits: Better resource cleanup guarantees, reduced external dependencies, clearer intent with standard library usage

✅ Checks

• Added test cases for my code

[coderabbitai]

📝 Walkthrough

Walkthrough

Refactored test path construction in view_test.go by replacing custom path.Resource calls with standard filepath.Join operations, updating imports accordingly, and implementing deferred directory cleanup for test resource directories.

Changes

Cohort / File(s)	Change Summary
Test Path Construction view_test.go	Replaced path.Resource usage with filepath.Join("resources", "views", ...) for test template file paths; imported filepath and removed path package; added deferred cleanup via defer blocks to remove "resources" directory after test execution instead of explicit removals; applied consistent path handling across Make, First, and CSRFToken test cases

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

🚥 Pre-merge checks | ✅ 1 | ❌ 2

❌ Failed checks (1 warning, 1 inconclusive)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.
Title check	❓ Inconclusive	The title 'chore: optimize tests' is vague and does not clearly convey the specific changes made. The PR replaces path.Resource with filepath.Join and introduces deferred cleanup, but the title only uses the generic term 'optimize' which doesn't describe these actual modifications.	Consider a more descriptive title that specifies the actual changes, such as 'chore: replace path.Resource with filepath.Join and add deferred cleanup in tests' or 'refactor: update test paths to use filepath.Join instead of path.Resource'.

✅ Passed checks (1 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch bowen/optimize-tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}