-
Notifications
You must be signed in to change notification settings - Fork 3
chore: add fmt cmd for outputs #40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @toaction, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds a code formatting step using go fmt for the generated Go bindings, which is a great enhancement for code quality. The implementation introduces a new codeFormat function. My review provides a suggestion to refactor this new function to avoid changing the process's global state and to align with idiomatic Go error handling practices.
Code Review SummaryThis PR successfully adds automatic Go code formatting to the llpyg tool - a valuable enhancement for code quality. The implementation follows existing patterns well and integrates cleanly into the workflow. Key findings:
Performance impact: Minimal overhead (~100-500ms for typical projects). The formatting step scales linearly with generated code size but shouldn't significantly impact build times. Overall this is a good addition that will ensure generated bindings follow Go formatting standards. |
fe6f096 to
add75a4
Compare
a84d9a7 to
5a7bad4
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #40 +/- ##
==========================================
+ Coverage 44.46% 48.27% +3.80%
==========================================
Files 6 6
Lines 452 464 +12
==========================================
+ Hits 201 224 +23
+ Misses 232 217 -15
- Partials 19 23 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
f17b41a to
e2219e3
Compare
No description provided.