chore: unify symbol declaration location

[toaction]

No description provided.

[gemini-code-assist]

Summary of Changes

Hello @toaction, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request unifies the declaration of core data structures, symbol and module, by relocating them into a new ast package. This refactoring ensures that these types, which represent Python symbols and modules, have a single, consistent definition used throughout the codebase, improving maintainability and clarity for components that interact with these structures.

Highlights

• Centralized Type Definitions: The symbol and module struct definitions have been moved from _xtool/pydump/pydump.go and tool/pygen/symbol.go to a new, dedicated ast package.
• Exported Types: The symbol and module types are now exported as ast.Symbol and ast.Module, making them accessible across different packages.
• Codebase-Wide Type Updates: All references to the old symbol and module types across _xtool/pydump/pydump.go, tool/pygen/genfunc.go, and tool/pygen/pygen.go have been updated to use the new ast.Symbol and ast.Module types.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request is a good refactoring that unifies the Symbol and Module type definitions into a new ast package. This improves the code structure and maintainability. The changes are applied consistently across the codebase. I have a couple of suggestions to add documentation to the new exported types, following Go's best practices.

[niupilot]

Code Review Summary

This is a well-executed refactoring that improves code organization by moving symbol declarations to a more appropriate location. The changes follow Go best practices and create a cleaner dependency structure.

Strengths:

• Clean separation of concerns with AST types in dedicated package
• Consistent use of pyast alias to avoid naming conflicts
• No logic changes, reducing risk of bugs
• Improved maintainability and discoverability

Minor improvement needed: Import organization in pydump.go could follow Go conventions better (grouping standard library, third-party, then local imports).

[codecov]

Codecov Report

❌ Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 44.46%. Comparing base (4d9f6fe) to head (ae3169e).
⚠️ Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
tool/pygen/pygen.go	66.66%	1 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##             main      #38   +/-   ##
=======================================
  Coverage   44.46%   44.46%           
=======================================
  Files           6        6           
  Lines         452      452           
=======================================
  Hits          201      201           
  Misses        232      232           
  Partials       19       19           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.