Skip to content

Conversation

@MeteorsLiu
Copy link
Contributor

@MeteorsLiu MeteorsLiu commented Apr 11, 2025

This PR is provided solely as a reference for refactoring, which is unnecessary to be reviewed
The refactoring process will be split into multiple PRs for review.

@codecov
Copy link

codecov bot commented Apr 11, 2025

Codecov Report

Attention: Patch coverage is 22.84382% with 331 lines in your changes missing coverage. Please review.

Project coverage is 42.12%. Comparing base (4420420) to head (a5372d2).

Files with missing lines Patch % Lines
internal/actions/api.go 0.00% 244 Missing ⚠️
internal/actions/env/env.go 14.28% 48 Missing ⚠️
internal/actions/actions.go 26.08% 17 Missing ⚠️
...rnal/actions/parser/mappedversion/mappedversion.go 63.15% 7 Missing ⚠️
internal/actions/mappingtable/versions.go 86.84% 4 Missing and 1 partial ⚠️
internal/actions/text.go 0.00% 4 Missing ⚠️
internal/actions/tag/tag.go 80.00% 2 Missing and 1 partial ⚠️
internal/actions/parser/prefix/prefix.go 91.30% 1 Missing and 1 partial ⚠️
cmd/llpkgstore/internal/verification.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #51      +/-   ##
==========================================
+ Coverage   40.85%   42.12%   +1.26%     
==========================================
  Files          33       38       +5     
  Lines        1745     1842      +97     
==========================================
+ Hits          713      776      +63     
- Misses        947      979      +32     
- Partials       85       87       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@qiniu-x
Copy link
Contributor

qiniu-x bot commented Apr 14, 2025

[Git-flow] Hi @MeteorsLiu, There are some suggestions for your information:


Rebase suggestions

  • Following commits seems generated via git merge

    Merge remote-tracking branch 'llpkg/main' into refactor-actions

  • Following commits have duplicated messages

    chore: add comment

    chore: add comment

    chore: add mappedversion test

    chore: add mappedversion test

Which seems insignificant, recommend to use git rebase command to reorganize your PR.

For other git-flow instructions, recommend refer to these examples.

Details

If you have any questions about this comment, feel free to raise an issue here:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant