docs: add comment noting moduleOf always fetches formula from latest commit #97
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add module loading functionality with MVS-based dependency resolution. Includes the Load function for loading packages and resolving their dependencies, version handling, and test data for various module loading scenarios.
Add concurrency safety to the modules package by: - Replace map-based moduleCache with sync.Map for thread-safe access - Introduce loadMu mutex to serialize ixgo interpreter loading to prevent internal race conditions during concurrent operations - Add mutex protection (m.mu) for formula map access within formulaModule - Refactor comparator loading using sync.OnceValues for lazy initialization - Extract loadOrDefaultComparator function for cleaner comparator handling These changes prevent data races when Load() and formula.LoadFS are called concurrently, as the ixgo interpreter has internal race conditions that require serialized access.
- Replace context.TODO() with the provided ctx parameter to respect the caller's context - Remove hardcoded context.WithTimeout wrapper that was constraining operations to 10 minutes - Remove unused time import - Simplify context propagation throughout the Load function
- Add documentation for exported Module struct - Fix Options comment: LoadPackages -> Load - Fix FormulaStore field comment: FormulaRepo -> FormulaStore - Fix Load function comment: LoadPackages -> Load, formulas -> modules Generated with [codeagent](https://github.com/qbox/codeagent) Co-authored-by: MeteorsLiu <17515813+MeteorsLiu@users.noreply.github.com>
…commit The moduleOf closure uses FormulaStore.ModuleFS which syncs with an empty ref, meaning formulas are always fetched from the latest commit on the default branch of the formula repository. Generated with [codeagent](https://github.com/qbox/codeagent) Co-authored-by: luoliwoshang <51194195+luoliwoshang@users.noreply.github.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #97 +/- ##
==========================================
+ Coverage 70.24% 73.25% +3.00%
==========================================
Files 26 27 +1
Lines 1099 1286 +187
==========================================
+ Hits 772 942 +170
- Misses 259 268 +9
- Partials 68 76 +8 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Collaborator
|
Cherry-picked to #94 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requested by @luoliwoshang
Summary