Skip to content

feat(spx-gui): support editing user display name in profile modal #2840

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
aofei wants to merge 1 commit into
base: dev
Choose a base branch
from
+22 −6
Open

feat(spx-gui): support editing user display name in profile modal #2840

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion spx-gui/src/apis/user.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,15 @@ export async function getSignedInUser(): Promise<SignedInUser> {
return await (client.get(`/user`) as Promise<SignedInUser>)
}

export type UpdateSignedInUserParams = Pick<User, 'description'>
export type UpdateSignedInUserParams =
| {
displayName: User['displayName']
description?: User['description']
}
| {
displayName?: User['displayName']
description: User['description']
}

export async function updateSignedInUser(params: UpdateSignedInUserParams) {
return await (client.put(`/user`, params) as Promise<SignedInUser>)
Expand Down
18 changes: 13 additions & 5 deletions spx-gui/src/components/community/user/EditProfileModal.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,9 +24,15 @@ const coverImgUrl = computed(() => getCoverImgUrl(props.user.username))
const avatarUrl = useAvatarUrl(() => props.user.avatar)

const form = useForm({
displayName: [props.user.displayName, validateDisplayName],
description: [props.user.description, validateDescription]
})

function validateDisplayName(val: string) {
if (val.trim() === '') return t({ en: 'The name must not be blank', zh: '名字不可为空' })
return null
}

function validateDescription(val: string) {
if (val.length > 200) return t({ en: 'The input must be 200 characters or fewer', zh: '输入不能超过 200 字' })
return null
Expand All @@ -39,7 +45,10 @@ function handleCancel() {
const updateProfile = useUpdateSignedInUser()

const handleSubmit = useMessageHandle(async () => {
const updated = await updateProfile({ description: form.value.description })
const updated = await updateProfile({
displayName: form.value.displayName.trim(),
description: form.value.description.trim()
})
emit('resolved', updated)
})
</script>
Expand All @@ -55,11 +64,10 @@ const handleSubmit = useMessageHandle(async () => {
<div class="cover" :style="{ backgroundImage: `url(${coverImgUrl})` }"></div>
<UIImg class="avatar" :src="avatarUrl" />
<UIForm :form="form" has-success-feedback @submit="handleSubmit.fn">
<UIFormItem :label="$t({ en: 'Name', zh: '名字' })">
<UIFormItem :label="$t({ en: 'Name', zh: '名字' })" path="displayName">
<UITextInput
v-radar="{ name: 'User name input', desc: 'Input field showing the user name' }"
:value="user.displayName"
disabled
v-model:value="form.value.displayName"
v-radar="{ name: 'User name input', desc: 'Input field for user display name' }"
/>
</UIFormItem>
<UIFormItem :label="$t({ en: 'About me', zh: '关于我' })" path="description">
Expand Down