Persistence for generation state #2832
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary of ChangesHello @nighca, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly refactors the application's persistence layer by introducing a dedicated application context ( Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a significant refactoring aimed at centralizing project persistence logic. Helper classes (CloudHelpers, LocalHelpers, XbpHelpers) are introduced and provided through a Vue context, which is a great improvement over instantiating them everywhere. The Project class is renamed to SpxProject and its persistence-related methods have been moved to these new helpers. Additionally, history management has been moved from the project model to the EditorState. The file structure for models has also been reorganized under models/spx.
While this is a solid architectural improvement, I've found a critical issue where properties related to asset generation state (spriteGens, backdropGens) have been removed from EditorState but are still being accessed by other components, which will lead to runtime errors. There are also some incomplete implementations for the new generation state persistence feature. Please address these points.
| } | ||
| } | ||
|
|
||
| export class EditorState extends Disposable { |
There was a problem hiding this comment.
The properties spriteGens, backdropGens, and their management methods (addSpriteGen, removeSpriteGen, etc.) have been removed from EditorState. However, other components like SpriteList.vue still access editorCtx.state.spriteGens. This will cause a runtime error. It seems the intention was to move this logic into the new GenManager class, but GenManager is not used within EditorState. These properties should be restored or the dependent components should be updated to use the new GenManager.
Comment on lines
+168
to
+170
| static load(serialized: PhaseSerialized): Phase<unknown> { | ||
| const phase = new Phase(serialized.actionName, serialized.state) | ||
| } |
There was a problem hiding this comment.
The load method creates a phase instance but does not return it. It should return the created instance.
static load(serialized: PhaseSerialized): Phase<unknown> {
const phase = new Phase(serialized.actionName, serialized.state)
return phase
}
Comment on lines
+131
to
+138
| export(): Files { | ||
| // TODO | ||
| return {} | ||
| } | ||
|
|
||
| async load(files: Files) { | ||
| // TODO | ||
| } |
There was a problem hiding this comment.
The export and load methods are added but not implemented. This seems to be part of the work-in-progress for persisting generation state. Please ensure these are implemented to complete the feature.
Comment on lines
+394
to
+405
| static async loadAll(files: Files) { | ||
|
|
||
| } | ||
|
|
||
| static async load(files: Files) { | ||
| // TODO | ||
| } | ||
|
|
||
| export(): Files { | ||
| // TODO | ||
| return {} | ||
| } |
There was a problem hiding this comment.
The loadAll, load, and export methods are added but not implemented. This seems to be part of the work-in-progress for persisting generation state. Please ensure these are implemented to complete the feature.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #2579.