-
Notifications
You must be signed in to change notification settings - Fork 50
docs(api-spec): add project displayName field
#2830
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
Add `displayName` to the `Project` schema and related endpoints:
- Add optional `displayName` to `POST /project` request body, which
defaults to `name` if not provided
- Add optional `displayName` to `PUT /project/{owner}/{name}` request
body
- Update `keyword` parameter in `GET /projects/list` to search by
display name or name, and decouple its schema from `Project.name`
Signed-off-by: Aofei Sheng <aofei@aofeisheng.com>
Summary of ChangesHello @aofei, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the project API by introducing a Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Updates the OpenAPI 3.1 spec to introduce an optional displayName for projects and reflect related request/query behavior in the documented endpoints.
Changes:
- Add
displayNameto theProjectschema and toPOST /project+PUT /project/{owner}/{name}request bodies. - Update
GET /projects/listkeywordquery parameter to search by display name or name, and decouple it fromProject.name’s schema.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Code Review SummaryThe PR adds |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the OpenAPI specification to introduce a displayName for projects. This new field is integrated into the Project schema, the project creation (POST /project) and update (PUT /project/{owner}/{name}) endpoints, and the project listing endpoint (GET /projects/list) is updated to allow searching by displayName. The changes are clear and align with the stated objectives. I've added one suggestion to include a maxLength constraint on the new displayName property to enhance data validation and clarify the API contract for consumers.
Add
displayNameto theProjectschema and related endpoints:displayNametoPOST /projectrequest body, which defaults tonameif not provideddisplayNametoPUT /project/{owner}/{name}request bodykeywordparameter inGET /projects/listto search by display name or name, and decouple its schema fromProject.name