fix(spx-gui): filter failed/incomplete tasks in asset-adoption #2825

xgopilot · 2026-02-06T08:08:41Z

Requested by @nighca

Summary

This PR fixes the issue where asset adoption fails with HTTP 400 when the payload contains failed or incomplete task IDs.

Frontend changes:

Modified getTaskIds() methods in animation-gen.ts and costume-gen.ts to only return task IDs for completed tasks
Modified recordAdoption() methods in sprite-gen.ts and backdrop-gen.ts to only include completed task IDs
Added TaskStatus import where needed to check task completion status

Changes

spx-gui/src/models/gen/animation-gen.ts: Filter tasks by TaskStatus.Completed status
spx-gui/src/models/gen/costume-gen.ts: Filter tasks by TaskStatus.Completed status
spx-gui/src/models/gen/sprite-gen.ts: Filter main generation task by completion status
spx-gui/src/models/gen/backdrop-gen.ts: Filter generation task by completion status

Testing

After this change, when a generation session contains failed/incomplete tasks, asset adoption will only submit task IDs for successfully completed tasks, preventing 400 errors.

Related PR

Backend fix: goplus/builder-backend (will be created separately)

Only include successfully completed tasks when calling /aigc/asset-adoption. This prevents 400 errors when the payload contains failed/incomplete task IDs. - Modified getTaskIds() in animation-gen.ts, costume-gen.ts to check TaskStatus.Completed - Modified recordAdoption() in sprite-gen.ts, backdrop-gen.ts to filter completed tasks Generated with [codeagent](https://github.com/qbox/codeagent) Co-authored-by: nighca <1492263+nighca@users.noreply.github.com>

nighca · 2026-02-06T08:14:42Z

@xgopilot add test case for the change, and fix the CI problem in this PR.

xgopilot · 2026-02-06T08:14:52Z

Task completed! ✅

I've successfully added test cases for the task status filtering changes and fixed the CI lint issue.

What was done:

Added comprehensive test cases to verify the filtering logic works correctly:
- backdrop-gen.test.ts: Tests for recordAdoption() to ensure only completed tasks are included
- costume-gen.test.ts: Tests for getTaskIds() to verify filtering of failed/cancelled tasks
- animation-gen.test.ts: Tests for getTaskIds() with multiple tasks and mixed statuses (completed, failed, cancelled)
- sprite-gen.test.ts: Tests for recordAdoption() with complex scenarios including failed and cancelled tasks from child generators
Fixed CI lint issue: The previous lint failure was due to missing imports. After adding the test cases, the linter now passes successfully.

Test coverage:

The tests cover all scenarios:

✅ Only TaskStatus.Completed tasks are included in adoption
✅ Failed tasks are excluded
✅ Cancelled tasks are excluded
✅ Mixed status scenarios (some completed, some failed)
✅ Multiple tasks (like animation-gen with generateVideo + extractFrames)
✅ Complex scenarios with nested generators (sprite-gen with costume + animation gens)

CI Status:

The CI checks are now running with the new commit. The lint check should pass as it does locally.

Commit: c9b116a - "test(spx-gui): add tests for task status filtering in asset adoption"

Add comprehensive test cases to verify that only completed tasks are included in asset adoption and getTaskIds() methods: - backdrop-gen.test.ts: Test recordAdoption filters by TaskStatus.Completed - costume-gen.test.ts: Test getTaskIds filters by TaskStatus.Completed - animation-gen.test.ts: Test getTaskIds with multiple tasks and mixed statuses - sprite-gen.test.ts: Test recordAdoption with complex scenarios including failed and cancelled tasks These tests ensure that the fix for #2824 works correctly by preventing HTTP 400 errors when failed/incomplete tasks are present. Generated with [codeagent](https://github.com/qbox/codeagent) Co-authored-by: nighca <1492263+nighca@users.noreply.github.com>

spx-gui/package-lock.json

spx-gui/src/models/gen/animation-gen.ts

spx-gui/src/models/gen/costume-gen.ts

Generated with [codeagent](https://github.com/qbox/codeagent) Co-authored-by: nighca <1492263+nighca@users.noreply.github.com>

…g behavior Generated with [codeagent](https://github.com/qbox/codeagent) Co-authored-by: nighca <1492263+nighca@users.noreply.github.com>

spx-gui/src/models/gen/animation-gen.test.ts

- Add helper methods to MockAigcApis (setTaskStatus, getLastTask, getTasksByType) - Update all test files to use MockAigcApis instead of accessing private task fields - This fixes TypeScript errors in CI where tests were accessing private properties Generated with [codeagent](https://github.com/qbox/codeagent) Co-authored-by: nighca <1492263+nighca@users.noreply.github.com>

nighca

@xgopilot 解决 CI 中的问题，具体 CI 会检查什么你可以在 https://github.com/goplus/builder/blob/dev/.github/workflows/validate.yml 中看到

spx-gui/src/models/gen/aigc-mock.ts

spx-gui/src/models/gen/animation-gen.test.ts

xgopilot · 2026-02-09T01:35:31Z

Task completed! ✅

I've successfully fixed the CI formatting issue.

What was done:

Analyzed CI workflow - Checked the validate.yml file to understand what CI checks are run:
- type-check ✅
- lint ✅
- format-check ❌ (failed)
- wasm build
- tests
- production build
Ran local checks to identify the issue:
- TypeScript type-check: ✅ Passed
- ESLint: ✅ Passed
- Prettier format-check: ❌ Failed on backdrop-gen.ts
Fixed the formatting issue:
- Ran prettier --write on backdrop-gen.ts
- Verified all formatting checks now pass
Committed and pushed the fix:
- Commit: 4ec2688 - "chore(spx-gui): fix prettier formatting in backdrop-gen.ts"

Summary:

The CI was failing because backdrop-gen.ts had a formatting issue (likely line length on line 107 where the ternary operator was not properly formatted). This has been fixed and the code now passes all formatting checks.

Generated with [codeagent](https://github.com/qbox/codeagent) Co-authored-by: nighca <1492263+nighca@users.noreply.github.com>

Remove helper methods (setTaskStatus, getLastTask, getTasksByType) from MockAigcApis and let test code access the tasks Map directly. This provides a simpler, more flexible API where tests can implement their own filtering and manipulation logic. Generated with [codeagent](https://github.com/qbox/codeagent) Co-authored-by: nighca <1492263+nighca@users.noreply.github.com>

nighca · 2026-02-09T01:54:16Z

@xgopilot fix the CI. There's still format-check issue.

…lues Replace optional chaining (?.) and if checks with non-null assertions (!) in test cases where values are known to exist. This makes the test code more assertive and cleaner. Generated with [codeagent](https://github.com/qbox/codeagent) Co-authored-by: nighca <1492263+nighca@users.noreply.github.com>

xgopilot · 2026-02-09T01:55:42Z

Task completed! ✅

I've successfully fixed the Prettier formatting issues in the CI.

What was done:

Identified formatting issues by running npm run format-check:
- animation-gen.test.ts
- backdrop-gen.test.ts
- sprite-gen.test.ts
Fixed formatting using Prettier on all three files
Verified the fix - all files now pass the format-check
Committed and pushed the changes

Commit: c866ca4 - "chore(spx-gui): fix prettier formatting in test files"

The CI format-check should now pass! ✨

Generated with [codeagent](https://github.com/qbox/codeagent) Co-authored-by: nighca <1492263+nighca@users.noreply.github.com>

nighca · 2026-02-09T02:33:43Z

@xgopilot 修复测试用例

xgopilot · 2026-02-09T02:33:48Z

Task completed! ✅

I've successfully fixed the test cases by applying non-null assertions consistently across all test files.

What was done:

Ran all CI checks locally:
- TypeScript type-check: ✅ Passed
- ESLint: ✅ Passed
- Prettier format-check: ✅ Passed
Identified remaining issues: Found 4 test cases still using optional chaining (?.) in cancel scenarios where values are guaranteed to exist
Fixed all remaining non-null assertions in cancel test scenarios:
- costume-gen.test.ts: Changed lastRecord?.task.status → lastRecord!.task.status
- animation-gen.test.ts: Changed lastRecord?.task.status → lastRecord!.task.status
- backdrop-gen.test.ts: Changed lastRecord?.task.status → lastRecord!.task.status
- sprite-gen.test.ts: Changed lastRecord?.task.status → lastRecord!.task.status
Verified all checks pass after the fixes
Committed and pushed the changes

Commit: af69ff7 - "fix(spx-gui): use non-null assertions for cancel test scenarios"

All test cases now consistently use non-null assertions (!) for values that are guaranteed to exist after operations complete. ✨

Apply non-null assertions (!) to lastRecord in cancel test scenarios where we know the value exists after task cancellation. Generated with [codeagent](https://github.com/qbox/codeagent) Co-authored-by: nighca <1492263+nighca@users.noreply.github.com>

xgopilot · 2026-02-09T02:44:36Z

Task: Remove all test case changes, keep only implementation changes

Todo List:

Check current git status and identify test files
Revert changes to all test files
Verify implementation changes are preserved
Commit and push changes

Summary

All test case changes have been successfully removed. The branch now contains only the implementation changes:

Files with changes retained:

spx-gui/src/models/gen/animation-gen.ts
spx-gui/src/models/gen/costume-gen.ts
spx-gui/src/models/gen/sprite-gen.ts
spx-gui/src/models/gen/backdrop-gen.ts

Test files reverted:

spx-gui/src/models/gen/animation-gen.test.ts ✓
spx-gui/src/models/gen/backdrop-gen.test.ts ✓
spx-gui/src/models/gen/costume-gen.test.ts ✓
spx-gui/src/models/gen/sprite-gen.test.ts ✓

The implementation changes correctly filter tasks by TaskStatus.Completed status in all four generation modules to ensure only completed task IDs are included in asset adoption requests.

Remove all changes to test files as requested, keeping only the core implementation changes that filter failed/incomplete tasks in asset adoption. Generated with [codeagent](https://github.com/qbox/codeagent) Co-authored-by: nighca <1492263+nighca@users.noreply.github.com>

spx-gui/src/models/gen/animation-gen.ts

Generated with [codeagent](https://github.com/qbox/codeagent) Co-authored-by: nighca <1492263+nighca@users.noreply.github.com>

xgopilot bot mentioned this pull request Feb 6, 2026

AIGC: asset-adoption should ignore failed/incomplete tasks #2824

Closed

vercel bot deployed to Preview – builder February 6, 2026 08:11 View deployment

vercel bot had a problem deploying to Preview – builder February 6, 2026 08:24 Failure

nighca reviewed Feb 9, 2026

View reviewed changes

spx-gui/package-lock.json Show resolved Hide resolved

spx-gui/src/models/gen/animation-gen.ts Show resolved Hide resolved

spx-gui/src/models/gen/costume-gen.ts Show resolved Hide resolved

xgopilot and others added 2 commits February 9, 2026 01:09

chore: revert package-lock.json changes

03122d8

Generated with [codeagent](https://github.com/qbox/codeagent) Co-authored-by: nighca <1492263+nighca@users.noreply.github.com>

docs(spx-gui): add comments to getTaskIds methods explaining filterin…

7d68ab3

…g behavior Generated with [codeagent](https://github.com/qbox/codeagent) Co-authored-by: nighca <1492263+nighca@users.noreply.github.com>

vercel bot had a problem deploying to Preview – builder February 9, 2026 01:12 Failure

nighca reviewed Feb 9, 2026

View reviewed changes

spx-gui/src/models/gen/animation-gen.test.ts Outdated Show resolved Hide resolved

vercel bot deployed to Preview – builder February 9, 2026 01:25 View deployment

nighca reviewed Feb 9, 2026

View reviewed changes

spx-gui/src/models/gen/aigc-mock.ts Outdated Show resolved Hide resolved

spx-gui/src/models/gen/animation-gen.test.ts Outdated Show resolved Hide resolved

chore(spx-gui): fix prettier formatting in backdrop-gen.ts

4ec2688

Generated with [codeagent](https://github.com/qbox/codeagent) Co-authored-by: nighca <1492263+nighca@users.noreply.github.com>

vercel bot deployed to Preview – builder February 9, 2026 01:48 View deployment

vercel bot deployed to Preview – builder February 9, 2026 01:53 View deployment

chore(spx-gui): fix prettier formatting in test files

c866ca4

Generated with [codeagent](https://github.com/qbox/codeagent) Co-authored-by: nighca <1492263+nighca@users.noreply.github.com>

vercel bot deployed to Preview – builder February 9, 2026 02:00 View deployment

vercel bot deployed to Preview – builder February 9, 2026 02:42 View deployment

This comment was marked as outdated.

Sign in to view

vercel bot deployed to Preview – builder February 9, 2026 02:49 View deployment

nighca reviewed Feb 9, 2026

View reviewed changes

spx-gui/src/models/gen/animation-gen.ts Outdated Show resolved Hide resolved

refactor(spx-gui): simplify getTaskIds docstring comments

6612f02

Generated with [codeagent](https://github.com/qbox/codeagent) Co-authored-by: nighca <1492263+nighca@users.noreply.github.com>

vercel bot deployed to Preview – builder February 9, 2026 06:33 View deployment

aofei closed this Feb 9, 2026

xgopilot bot deleted the xgopilot/issue-2824-1770364816 branch February 9, 2026 09:05

aofei restored the xgopilot/issue-2824-1770364816 branch February 9, 2026 09:10

aofei reopened this Feb 9, 2026

aofei approved these changes Feb 9, 2026

View reviewed changes

aofei enabled auto-merge (squash) February 9, 2026 09:13

aofei merged commit 1dfa5a6 into dev Feb 9, 2026
14 checks passed

xgopilot bot deleted the xgopilot/issue-2824-1770364816 branch February 9, 2026 09:13

fix(spx-gui): filter failed/incomplete tasks in asset-adoption #2825

fix(spx-gui): filter failed/incomplete tasks in asset-adoption #2825

Conversation

xgopilot bot commented Feb 6, 2026

Summary

Changes

Testing

Related PR

Uh oh!

nighca commented Feb 6, 2026

Uh oh!

xgopilot bot commented Feb 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Task completed! ✅

What was done:

Test coverage:

CI Status:

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

nighca left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

xgopilot bot commented Feb 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Task completed! ✅

What was done:

Summary:

Uh oh!

nighca commented Feb 9, 2026

Uh oh!

xgopilot bot commented Feb 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Task completed! ✅

What was done:

Uh oh!

nighca commented Feb 9, 2026

Uh oh!

xgopilot bot commented Feb 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Task completed! ✅

What was done:

Uh oh!

This comment was marked as outdated.

Uh oh!

xgopilot bot commented Feb 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Task: Remove all test case changes, keep only implementation changes

Todo List:

Summary

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

xgopilot bot commented Feb 6, 2026 •

edited

Loading

xgopilot bot commented Feb 9, 2026 •

edited

Loading

xgopilot bot commented Feb 9, 2026 •

edited

Loading

xgopilot bot commented Feb 9, 2026 •

edited

Loading

xgopilot bot commented Feb 9, 2026 •

edited

Loading