AnglePicker snaps back to the previous value after a quick click #2587
Conversation
Summary of ChangesHello @Overu, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses a specific bug in the AnglePicker component that caused heading values to snap back to their prior state after a rapid user interaction. The change ensures that updates to a sprite's heading are correctly processed and maintained, enhancing the stability and reliability of user input within the sprite configuration interface. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request addresses an issue where the AnglePicker component would incorrectly snap back to a previous value after a quick interaction. The root cause was a double-debouncing mechanism, one within the AnglePicker itself and another in the handleHeadingUpdate function in the parent component. The fix involves removing the redundant debounce from handleHeadingUpdate by passing false to wrapUpdateHandler. This ensures that value updates are processed immediately, resolving the synchronization problem and preventing the snap-back behavior. This change also improves consistency with handleRotationStyleUpdate in the same file. The fix is correct and improves the component's responsiveness and reliability.
| const handleHeadingUpdate = wrapUpdateHandler( | ||
| (h: number | null) => props.sprite.setHeading(h ?? 0), | ||
| spriteContext, | ||
| false | ||
| ) |
There was a problem hiding this comment.
在 AnglePicker 做了 防抖。这里再做一次，会导致 第二次数值 变化可能被 第一次的值 覆盖。
例如：
第一次选择 130度，300ms 后更新值，300ms 后更新 sprite
这时候快速选择 150度，界面变成 150度。sprite 同步回来，把 150度 变成 130度.
There was a problem hiding this comment.
在 #2567 中，SpriteDirection.vue 被移除了，相关的功能挪到了 HeadingConfigPanel.vue, 需要同步修改
2 participants
Fixed #2559