-
Notifications
You must be signed in to change notification settings - Fork 50
Feat/authorize #2265
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
thewindwillstop
wants to merge
3
commits into
goplus:trailhead_copilot
Choose a base branch
from
thewindwillstop:feat/authorize
base: trailhead_copilot
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Feat/authorize #2265
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,203 @@ | ||
| package main | ||
|
|
||
| import ( | ||
| "context" | ||
| "encoding/json" | ||
| "net/http" | ||
| "net/http/httptest" | ||
| "testing" | ||
|
|
||
| "github.com/goplus/builder/spx-backend/internal/authn" | ||
| "github.com/goplus/builder/spx-backend/internal/model" | ||
| "github.com/goplus/yap" | ||
| "github.com/stretchr/testify/assert" | ||
| "github.com/stretchr/testify/require" | ||
| ) | ||
|
|
||
| func createTestUser() *model.User { | ||
| return &model.User{ | ||
| Model: model.Model{ | ||
| ID: 1, | ||
| }, | ||
| Username: "testuser", | ||
| } | ||
| } | ||
|
|
||
| func TestEnsureAuthenticatedUserFunction(t *testing.T) { | ||
| t.Run("WithAuthenticatedUser", func(t *testing.T) { | ||
| user := createTestUser() | ||
| ctx := authn.NewContextWithUser(context.Background(), user) | ||
| recorder := httptest.NewRecorder() | ||
|
|
||
| // Create yap context similar to how it's done in the .yap files | ||
| yapCtx := &yap.Context{} | ||
| yapCtx.Request = httptest.NewRequest("GET", "/test", nil).WithContext(ctx) | ||
| yapCtx.ResponseWriter = recorder | ||
|
|
||
| mUser, ok := ensureAuthenticatedUser(yapCtx) | ||
|
|
||
| assert.True(t, ok, "Should return true for authenticated user") | ||
| assert.Equal(t, user, mUser, "Should return the same user") | ||
| // When user is authenticated, no response should be written by ensureAuthenticatedUser | ||
| // But yap might set a default 200 status, so we check it didn't write an error | ||
| assert.NotEqual(t, http.StatusUnauthorized, recorder.Code, "Should not write unauthorized response") | ||
| }) | ||
|
|
||
| t.Run("WithoutAuthenticatedUser", func(t *testing.T) { | ||
| ctx := context.Background() | ||
| recorder := httptest.NewRecorder() | ||
|
|
||
| // Create yap context without user | ||
| yapCtx := &yap.Context{} | ||
| yapCtx.Request = httptest.NewRequest("GET", "/test", nil).WithContext(ctx) | ||
| yapCtx.ResponseWriter = recorder | ||
|
|
||
| mUser, ok := ensureAuthenticatedUser(yapCtx) | ||
|
|
||
| assert.False(t, ok, "Should return false for unauthenticated user") | ||
| assert.Nil(t, mUser, "Should return nil user") | ||
|
|
||
| // Check that unauthorized response was written | ||
| assert.Equal(t, http.StatusUnauthorized, recorder.Code) | ||
| assert.Equal(t, "Bearer", recorder.Header().Get("WWW-Authenticate")) | ||
|
|
||
| // Check error response body | ||
| var errorResp errorPayload | ||
| err := json.Unmarshal(recorder.Body.Bytes(), &errorResp) | ||
| require.NoError(t, err) | ||
| assert.Equal(t, errorUnauthorized, errorResp.Code) | ||
| assert.Equal(t, "Unauthorized", errorResp.Msg) | ||
| }) | ||
| } | ||
|
|
||
| func TestErrorHandling(t *testing.T) { | ||
| tests := []struct { | ||
| name string | ||
| code errorCode | ||
| expectedHTTP int | ||
| expectedMsg string | ||
| expectWWWAuth bool | ||
| }{ | ||
| { | ||
| name: "Unauthorized", | ||
| code: errorUnauthorized, | ||
| expectedHTTP: 401, | ||
| expectedMsg: "Unauthorized", | ||
| expectWWWAuth: true, | ||
| }, | ||
| { | ||
| name: "Forbidden", | ||
| code: errorForbidden, | ||
| expectedHTTP: 403, | ||
| expectedMsg: "Forbidden", | ||
| expectWWWAuth: false, | ||
| }, | ||
| { | ||
| name: "NotFound", | ||
| code: errorNotFound, | ||
| expectedHTTP: 404, | ||
| expectedMsg: "Not found", | ||
| expectWWWAuth: false, | ||
| }, | ||
| } | ||
|
|
||
| for _, tt := range tests { | ||
| t.Run(tt.name, func(t *testing.T) { | ||
| recorder := httptest.NewRecorder() | ||
| yapCtx := &yap.Context{} | ||
| yapCtx.ResponseWriter = recorder | ||
|
|
||
| replyWithCode(yapCtx, tt.code) | ||
|
|
||
| assert.Equal(t, tt.expectedHTTP, recorder.Code) | ||
|
|
||
| if tt.expectWWWAuth { | ||
| assert.Equal(t, "Bearer", recorder.Header().Get("WWW-Authenticate")) | ||
| } else { | ||
| assert.Empty(t, recorder.Header().Get("WWW-Authenticate")) | ||
| } | ||
|
|
||
| var errorResp errorPayload | ||
| err := json.Unmarshal(recorder.Body.Bytes(), &errorResp) | ||
| require.NoError(t, err) | ||
| assert.Equal(t, tt.code, errorResp.Code) | ||
| assert.Equal(t, tt.expectedMsg, errorResp.Msg) | ||
| }) | ||
| } | ||
| } | ||
|
|
||
| // Test that demonstrates the authentication flow as used in the .yap files | ||
| func TestYapFileAuthFlow(t *testing.T) { | ||
| t.Run("SimulatePostImageYapWithAuth", func(t *testing.T) { | ||
| user := createTestUser() | ||
| ctx := authn.NewContextWithUser(context.Background(), user) | ||
|
|
||
| req := httptest.NewRequest("POST", "/image", nil) | ||
| req = req.WithContext(ctx) | ||
| recorder := httptest.NewRecorder() | ||
|
|
||
| // Simulate the exact flow from post_image.yap | ||
| handler := http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) { | ||
| yapCtx := &yap.Context{} | ||
| yapCtx.Request = r | ||
| yapCtx.ResponseWriter = w | ||
|
|
||
| // This is the exact check from our modified .yap files | ||
| if _, ok := ensureAuthenticatedUser(yapCtx); !ok { | ||
| return | ||
| } | ||
|
|
||
| // If we get here, authentication succeeded | ||
| // Simulate successful image generation response | ||
| response := map[string]interface{}{ | ||
| "id": "test-image-123", | ||
| "svg_url": "https://example.com/image.svg", | ||
| "status": "success", | ||
| } | ||
|
|
||
| yapCtx.JSON(200, response) | ||
| }) | ||
|
|
||
| handler.ServeHTTP(recorder, req) | ||
|
|
||
| assert.Equal(t, http.StatusOK, recorder.Code) | ||
|
|
||
| var response map[string]interface{} | ||
| err := json.Unmarshal(recorder.Body.Bytes(), &response) | ||
| require.NoError(t, err) | ||
| assert.Equal(t, "test-image-123", response["id"]) | ||
| assert.Equal(t, "success", response["status"]) | ||
| }) | ||
|
|
||
| t.Run("SimulatePostImageYapWithoutAuth", func(t *testing.T) { | ||
| // No user in context - simulates unauthenticated request | ||
| req := httptest.NewRequest("POST", "/image", nil) | ||
| recorder := httptest.NewRecorder() | ||
|
|
||
| // Simulate the exact flow from post_image.yap | ||
| handler := http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) { | ||
| yapCtx := &yap.Context{} | ||
| yapCtx.Request = r | ||
| yapCtx.ResponseWriter = w | ||
|
|
||
| // This should fail and return early | ||
| if _, ok := ensureAuthenticatedUser(yapCtx); !ok { | ||
| return | ||
| } | ||
|
|
||
| // This should NOT be reached | ||
| t.Fatal("Handler should not reach this point without authentication") | ||
| }) | ||
|
|
||
| handler.ServeHTTP(recorder, req) | ||
|
|
||
| assert.Equal(t, http.StatusUnauthorized, recorder.Code) | ||
| assert.Equal(t, "Bearer", recorder.Header().Get("WWW-Authenticate")) | ||
|
|
||
| var errorResp errorPayload | ||
| err := json.Unmarshal(recorder.Body.Bytes(), &errorResp) | ||
| require.NoError(t, err) | ||
| assert.Equal(t, errorUnauthorized, errorResp.Code) | ||
| }) | ||
|
|
||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Replace hard-coded test values with randomized data to improve test isolation and prevent potential conflicts between test runs. Add import for 'math/rand' and 'fmt' at the top of the file.