feat(config): add support for double wildcard in onbranch #11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit introduces support for double wildcard (`**`) patterns in `includeIf.onbranch` conditions. The standard `filepath.Match` function does not support this, so we've switched to using the `github.com/gobwas/glob` library, which provides this functionality. The implementation involves: - Adding the `github.com/gobwas/glob` dependency. - Creating a new `globMatch` function that uses this library with path separators enabled. - Updating the `matchSubSection` function to use `globMatch` for `onbranch` conditions. - Expanding the test suite to verify the new double wildcard behavior, including a case that ensures `*` does not match across path separators.
Contributor
Author
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll acknowledge your comments with a 👀 emoji and then get to work. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! I will automatically address your feedback. For any comments you don't want me to act on, just include (aside). For security, I will only act on instructions from the user who triggered this task for this pull request. |
dominikschulz
approved these changes
Sep 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds support for
**inincludeIf.onbranchconditions by replacingfilepath.Matchwith a globbing library that supports this feature. Tests have been added to verify the new functionality.PR created automatically by Jules for task 2462585007542734631