UserService 인터페이스 분리 및 역할 기반 리팩터링 #231
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hen715
approved these changes
May 10, 2025
| SignUpResponse response = userSignUpService.signUp(request); | ||
|
|
||
| // then | ||
| assertNotNull(response); |
Contributor
There was a problem hiding this comment.
해당 방식은 첫 줄에서 실패하면 그대로 테스트가 끝나서 assertAll로 묶어서 한 번에 테스트 하는 방향도 추천드려요!
Member
Author
There was a problem hiding this comment.
좋은 의견 감사합니다!
저는 테스트가 성공하는 케이스니까, 처음 실패하면 바로 종료돼도 괜찮다고 생각했었는데요, 말씀해주신 것처럼 전체 검증을 묶어서 실행하면 더 많은 정보를 한 번에 확인할 수 있어서 훨씬 좋은 방법인 것 같네요!
assertAll로 묶어서 테스트 작성하는 것으로 수정해보겠습니다!
… 강화, when -> given, verify -> then 스타일로 변경하여 BDD 가독성 향상
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 Issue
🧐 현재 상황
🎯 목표
🛠 작업 내용
작업 할 내용을 입력해주세요.
서비스 분리
테스트 수정
🚀 기타 사항