This repository was archived by the owner on Jun 1, 2023. It is now read-only.
Move SmallCityServiceTest and create BusinessesServiceTest #96
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LindseyWeiskopf
requested review from
AbakirH,
KSullivan42,
ethanimooney and
nightrunner500
| private final MapLocation TEST_MAP_LOCATION = new MapLocation(39.459836, -76.742536); | ||
| private final String TEST_PRODUCT = "pizza"; | ||
|
|
||
| private final List<Listing> TEST_PASSED_LIST = new LinkedList<>(); |
There was a problem hiding this comment.
List of what exactly? Businesses? BigBusinesses? SmallBusiness?
Contributor
Author
There was a problem hiding this comment.
I changed the name to TEST_ALL_BUSINESSES which is the name of the parameter passed into the businesses service constructor - does that make more sense?
Comment on lines
16
to
17
| private final int MIN_LISTINGS_RETURNED = 20; | ||
| private final int MAX_LISTINGS_RETURNED = 60; |
| Assert.assertTrue(actual.size() >= MIN_LISTINGS_RETURNED); | ||
| Assert.assertTrue(actual.size() <= MAX_LISTINGS_RETURNED); | ||
|
|
||
| int containsCounter = 0; |
There was a problem hiding this comment.
Not sure I follow this naming pattern.
Contributor
Author
There was a problem hiding this comment.
I changed the name of this variable - let me know if it makes more sense now
ethanimooney
approved these changes
Aug 7, 2020
Contributor
ethanimooney
left a comment
ethanimooney
left a comment
There was a problem hiding this comment.
Just gotta get one last LGTM in :)
For real though, these look good!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Create tests to test places API aspects of Businesses service class
SmallCityServiceTest.java: Moved the tests that were in the former BigBusinessesTest.java file to a new SmallCityServicesTest.java file
BusinessesServiceTest.java: Using the Mockito framework, I created tests for the getBusinessesByTextSearch() and getBusinessesByNearbySearch() functions. I created a mock list of businesses known to be returned by the places API given the test map location. The test checks to see if the list returned by the actual functions are the correct length (between 20 and 60 businesses) and contain all 3 of the expected businesses as returned from the mock.
There is definitely more to be done here, but it depends if time allows for it! I just wanted to get this our sooner rather than later!