Skip to content

Conversation

@a-detiste
Copy link
Contributor

@gemini-code-assist
Copy link

Summary of Changes

Hello @a-detiste, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refines the project's dependency management by accurately reflecting its runtime requirements. It specifically removes setuptools from the list of runtime dependencies, acknowledging its role as primarily a build-time tool rather than an essential component for the application's execution. This adjustment contributes to a more precise and potentially leaner dependency tree.

Highlights

  • Dependency Management: The setuptools package has been removed from the runtime dependencies list in pyproject.toml.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@a-detiste a-detiste changed the title "setuptools" is not required at runtime chore(deps): "setuptools" is not required at runtime Jan 23, 2026
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes setuptools from the project's runtime dependencies in pyproject.toml. This is a correct and beneficial change. My review of the codebase confirms that setuptools is not used at runtime. The project correctly uses importlib.metadata for package introspection, which is the modern approach and avoids a runtime dependency on setuptools. Furthermore, setuptools is explicitly on a denylist within the project's own dependency resolution logic, which reinforces the fact that it is not intended as a runtime dependency. This change reduces unnecessary dependency bloat for end-users. I approve of this merge.

@simoncozens
Copy link
Contributor

Thanks for this, @a-detiste! (No particular thanks to the other guy, though.)

@simoncozens simoncozens merged commit a4d2517 into googlefonts:main Jan 23, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants