make consistent use of 'GOOG' as openTypeOS2VendorID#30
Open
petergardfjall wants to merge 1 commit intogooglefonts:mainfrom
Open
make consistent use of 'GOOG' as openTypeOS2VendorID#30petergardfjall wants to merge 1 commit intogooglefonts:mainfrom
petergardfjall wants to merge 1 commit intogooglefonts:mainfrom
Conversation
Prior to this commit the `openTypeOS2VendorID` was not consistent across all font variants. In particular, the italic variants used `pyrs` as vendor ID, whereas the rest of the variants used `GOOG`. This appears to confuse certain applications (such as Emacs), which failed to recognize the italic variants of the font.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses #23
Prior to this commit the
openTypeOS2VendorIDwas not consistent across allfont variants. In particular, the italic variants used
pyrsas vendor ID,whereas the rest of the variants used
GOOG. This appears to confuse certainapplications (such as Emacs), which fails to recognize the italic variants of
the font.