Skip to content
This repository was archived by the owner on Sep 3, 2022. It is now read-only.

Dependency fix for google-cloud-monitoring, six, pandas-profiling.#717

Merged
rileyjbauer merged 5 commits intogoogledatalab:masterfrom
mikehcheng:fix-google-cloud-monitoring
Jul 23, 2019
Merged

Dependency fix for google-cloud-monitoring, six, pandas-profiling.#717
rileyjbauer merged 5 commits intogoogledatalab:masterfrom
mikehcheng:fix-google-cloud-monitoring

Conversation

@mikehcheng
Copy link
Copy Markdown
Contributor

Extends #702, includes #714. Fixes #715.

@coveralls
Copy link
Copy Markdown

coveralls commented Jul 20, 2019

Coverage Status

Coverage increased (+0.08%) to 77.873% when pulling 4fc7f4f on mikehcheng:fix-google-cloud-monitoring into d903190 on googledatalab:master.

rileyjbauer and others added 5 commits July 22, 2019 13:08
…ecause it seems the google.cloud.monitoring library made a significant change from a single Client class to a series of smaller ServiceClients, and our code seems to assume we have a single object with the functionality of multiple of these ServiceClients in various places.
Copy link
Copy Markdown
Contributor

@rileyjbauer rileyjbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for all the work getting these libraries updated!

@rileyjbauer rileyjbauer merged commit 6356193 into googledatalab:master Jul 23, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants