This repository was archived by the owner on Mar 13, 2018. It is now read-only.
Maybe fixes #207? Force upgrades before highlighting.#254
Open
arthurevans wants to merge 1 commit intomasterfrom
Open
Maybe fixes #207? Force upgrades before highlighting.#254arthurevans wants to merge 1 commit intomasterfrom
arthurevans wants to merge 1 commit intomasterfrom
Conversation
Contributor
Author
|
Unfortunately, this issue is intermittent, and I haven't found any reliable way to reproduce it. Assuming this patch doesn't make anything worse (so far as I can tell, it doesn't), perhaps we could roll it out for a while and ask folks to keep an eye out for this problem. |
Contributor
Author
|
More "correct" fix here would be to rework the racy connection between the guides page and the highlighter element. For example, have the prism-highlighter element fire an even on attached, upon receipt of which page retries the highlight request. Or, just have the page call a method directly on the element. Better long-term fix might be to doing highlighting as a build step or on the server-side instead of offloading to the client. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
Polymer.dom.flush()call should force any pending upgrades to complete, meaning that the prism-highlighter should be attached before we fire the highlight events. See the bug description in #207 for analysis of what we think's going on here...Also, use
Polymer.dom()correctly. Existing code was callingscopeSubtreeinstead of doing the right thing.