Skip to content
This repository was archived by the owner on Dec 15, 2018. It is now read-only.

Comments

Compatibility with async loading of Google Maps#11

Closed
fhackenberger wants to merge 5 commits intogooglearchive:gh-pagesfrom
fhackenberger:gh-pages
Closed

Compatibility with async loading of Google Maps#11
fhackenberger wants to merge 5 commits intogooglearchive:gh-pagesfrom
fhackenberger:gh-pages

Conversation

@fhackenberger
Copy link

Hi!

In order to use the library, I changed the code to use its own namespace (googlemaps.jsMapLabel) and added lazy loading support, by calling an init function (not requires when google.maps is already available on script load).

This pull request also adds high DPI screen support from https://github.com/daniellmb/js-map-label fixes an issue with alignment and adds a marginTop config option that I needed for my project here.

Best, Florian

This is useful to place the text above a marker icon
The canvas is always 300px wide, so in case the text is longer and
cut off, at least it still aligns correctly.
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@fhackenberger
Copy link
Author

Seems like #9 already has all of there. Please merge that one instead of mine.

@fhackenberger
Copy link
Author

I signed it!

On 06/09/2016 07:01 PM, googlebot wrote:

Thanks for your pull request. It looks like this may be your first
contribution to a Google open source project. Before we can look at
your pull request, you'll need to sign a Contributor License Agreement
(CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. |I signed it!|) and we'll
verify. Thanks.



You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#11 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/AA3mWHtyKJSGR86X063nSEknSc6B3zbMks5qKEbkgaJpZM4IyMQX.

DI Florian Hackenberger
florian@hackenberger.at
www.hackenberger.at

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants