Skip to content
This repository was archived by the owner on Mar 13, 2018. It is now read-only.

selected value should start out as false not null #44

Open
jakemac53 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

selected value should start out as false not null #44

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion core-list.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -693,7 +693,7 @@
physicalDatum.index = virtualIndex;
physicalDatum.physicalIndex = physicalIndex;
physicalDatum.selected = this.selectionEnabled && virtualDatum ?
this._selectedData.get(virtualDatum) : null;
(this._selectedData.get(virtualDatum) || false) : null;
// Set group-related fields
if (this._grouped) {
var groupModel = this.groups[groupIndex];
Expand Down
2 changes: 2 additions & 0 deletions test/core-list-basic.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,8 @@
item.templateInstance.model &&
item.templateInstance.model.index == index,
'top item index should be ' + index + ' ' + positionDescription);
chai.assert(item.templateInstance.model.selected == false,
'top item should start out with selected == false');
chai.assert(item.templateInstance.model.model == list.data[index],
'top item model should be data[' + index + '] ' + positionDescription);
chai.assert(item.querySelector('#index').textContent == index,
Expand Down