feat(php): support version string for gapics#1894
Open
Conversation
SurferJeffAtGoogle
approved these changes
Nov 7, 2023
parthea
approved these changes
Mar 18, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We added
version_stringto allow for copying "common" protos which don't contain a version string. We can also use it when we want to copy files over at any point which isn't the version. This happens often, when we want a package to also contain builds of its sub-packages.One example of this is in MapsFleetengine, where we want the build of
google/maps/fleetengine/deliveryto havetests,samples, and GAPICsrcto be prefixed by the directorysrc/Discovery:There are a few examples of this behavior, where we want to include generate GAPIC files, but we want to place them in a subdirectory. Other examples include:
Bigtable/src/Admin/V2Firestore/src/Admin/V1Workflows/src/Executions/V1