chore: librarian update image pull request: 20251215T144632Z#1245
chore: librarian update image pull request: 20251215T144632Z#1245daniel-sanche wants to merge 1 commit intomainfrom
Conversation
…prod/images-prod/python-librarian-generator@sha256:8b2565040b8f040cbdad8eb4f861a7f2156c6a87965c7baa2d942eb16a57ff19
|
One or more libraries have failed to generate, please review PR description for a list of failed libraries. |
Summary of ChangesHello @daniel-sanche, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request updates the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request, intended to update the librarian generator image, has inadvertently caused a critical failure. As noted in the description, the generation for google-cloud-bigtable failed. This has resulted in the deletion of a significant number of files related to the Bigtable Admin client, which constitutes a major breaking change. This PR should not be merged. The underlying generation failure needs to be investigated and resolved, and the deleted files must be restored.
| @@ -1,4 +1,4 @@ | |||
| image: us-central1-docker.pkg.dev/cloud-sdk-librarian-prod/images-prod/python-librarian-generator@sha256:8e2c32496077054105bd06c54a59d6a6694287bc053588e24debe6da6920ad91 | |||
| image: us-central1-docker.pkg.dev/cloud-sdk-librarian-prod/images-prod/python-librarian-generator@sha256:8b2565040b8f040cbdad8eb4f861a7f2156c6a87965c7baa2d942eb16a57ff19 | |||
There was a problem hiding this comment.
feat: update image to us-central1-docker.pkg.dev/cloud-sdk-librarian-prod/images-prod/python-librarian-generator@sha256:8b2565040b8f040cbdad8eb4f861a7f2156c6a87965c7baa2d942eb16a57ff19
Generation failed for