feat: add unique id to chat history items#503
Open
jrobinson01 wants to merge 3 commits intogoogleapis:mainfrom
Open
feat: add unique id to chat history items#503jrobinson01 wants to merge 3 commits intogoogleapis:mainfrom
jrobinson01 wants to merge 3 commits intogoogleapis:mainfrom
Conversation
product-auto-label
bot
added
the
api: aiplatform
Author
|
I should've tested further. This breaks in that vertex errors with a 400 complaining about the addition of the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds unique id's to chat history items to make manipulating history easier and less error prone. The
idis optional in theContenttype to avoid breaking typescript projects. I'm on the fence as to whether this should or shouldn't be optional, but it seems like making it mandatory would be a breaking change. I'm fine with this being a breaking change but wanted to first introduce the least disruptive change. There may be ramifications I'm not thinking of by making theidoptional.