Skip to content

feat: support SHOW DEFAULT_TRANSACTION_ISOLATION for PG databases #4285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
olavloite merged 1 commit into from
Jan 5, 2026
Merged

feat: support SHOW DEFAULT_TRANSACTION_ISOLATION for PG databases #4285

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions ...panner/src/main/java/com/google/cloud/spanner/connection/ConnectionStatementExecutor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,6 +152,8 @@ StatementResult statementSetPgSessionCharacteristicsTransactionMode(

StatementResult statementShowTransactionIsolationLevel();

StatementResult statementShowDefaultTransactionIsolation();

StatementResult statementSetProtoDescriptors(byte[] protoDescriptors);

StatementResult statementSetProtoDescriptorsFilePath(String filePath);
Expand Down
15 changes: 14 additions & 1 deletion ...er/src/main/java/com/google/cloud/spanner/connection/ConnectionStatementExecutorImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,7 @@
import static com.google.cloud.spanner.connection.StatementResult.ClientSideStatementType.SHOW_COMMIT_RESPONSE;
import static com.google.cloud.spanner.connection.StatementResult.ClientSideStatementType.SHOW_COMMIT_TIMESTAMP;
import static com.google.cloud.spanner.connection.StatementResult.ClientSideStatementType.SHOW_DATA_BOOST_ENABLED;
import static com.google.cloud.spanner.connection.StatementResult.ClientSideStatementType.SHOW_DEFAULT_TRANSACTION_ISOLATION;
import static com.google.cloud.spanner.connection.StatementResult.ClientSideStatementType.SHOW_DELAY_TRANSACTION_START_UNTIL_FIRST_WRITE;
import static com.google.cloud.spanner.connection.StatementResult.ClientSideStatementType.SHOW_DIRECTED_READ;
import static com.google.cloud.spanner.connection.StatementResult.ClientSideStatementType.SHOW_EXCLUDE_TXN_FROM_CHANGE_STREAMS;
Expand Down Expand Up @@ -647,7 +648,19 @@ public StatementResult statementShowReadLockMode() {

@Override
public StatementResult statementShowTransactionIsolationLevel() {
return resultSet("transaction_isolation", "serializable", SHOW_TRANSACTION_ISOLATION_LEVEL);
TransactionOptions.IsolationLevel isolationLevel =
getConnection().isInTransaction()
? getConnection().getTransactionIsolationLevel()
: getConnection().getDefaultIsolationLevel();
return resultSet("transaction_isolation", isolationLevel, SHOW_TRANSACTION_ISOLATION_LEVEL);
}

@Override
public StatementResult statementShowDefaultTransactionIsolation() {
return resultSet(
"default_transaction_isolation",
getConnection().getDefaultIsolationLevel(),
SHOW_DEFAULT_TRANSACTION_ISOLATION);
}

@Override
Expand Down
1 change: 1 addition & 0 deletions google-cloud-spanner/src/main/java/com/google/cloud/spanner/connection/StatementResult.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,6 +98,7 @@ enum ClientSideStatementType {
SET_RPC_PRIORITY,
SHOW_RPC_PRIORITY,
SHOW_TRANSACTION_ISOLATION_LEVEL,
SHOW_DEFAULT_TRANSACTION_ISOLATION,
SHOW_SAVEPOINT_SUPPORT,
SET_SAVEPOINT_SUPPORT,
SHOW_DATA_BOOST_ENABLED,
Expand Down
9 changes: 9 additions & 0 deletions ...anner/src/main/resources/com/google/cloud/spanner/connection/PG_ClientSideStatements.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -248,6 +248,15 @@
"method": "statementShowTransactionIsolationLevel",
"exampleStatements": ["show transaction isolation level","show variable transaction isolation level"]
},
{
"name": "SHOW [VARIABLE] DEFAULT_TRANSACTION_ISOLATION",
"executorName": "ClientSideStatementNoParamExecutor",
"resultType": "RESULT_SET",
"statementType": "SHOW_DEFAULT_TRANSACTION_ISOLATION",
"regex": "(?is)\\A\\s*show\\s+(?:variable\\s+)?default_transaction_isolation\\s*\\z",
"method": "statementShowDefaultTransactionIsolation",
"exampleStatements": ["show default_transaction_isolation","show variable default_transaction_isolation"]
},
{
"name": "EXPLAIN <sql>",
"executorName": "ClientSideStatementExplainExecutor",
Expand Down
Loading