feat(compliance): Add optional fields for all primitive types #1602
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coryan
approved these changes
Dec 19, 2025
Contributor
coryan
left a comment
coryan
left a comment
There was a problem hiding this comment.
A couple of questions, but neither is blocking. I would like @vchudnov-g to take a look if possible.
Comment on lines
+239
to
+247
| // The proto compiler seems to misgenerate optional bytes fields. | ||
| // The generated code looks like: | ||
| // ``` | ||
| // if cmd.Flags().Changed("info.p_bytes") { | ||
| // RepeatDataBodyInfoInput.Info.PBytes = &repeatDataBodyInfoInputInfoPBytes | ||
| // } | ||
| // ``` | ||
| // The dereference of `&repeatDataBodyInfoInputInfoPBytes` is incorrect since | ||
| // `repeatDataBodyInfoInputInfoPBytes` is already a `byte[]` |
Author
There was a problem hiding this comment.
I did not. I assumed that there was something weird about the tooling that Showcase is using since it seems impossible that the official golang proto compiler would misgenerate code for such a common type.
Comment on lines
+1344
to
+1346
| if req.GetReturnPartialSuccess() { | ||
| params.Add("returnPartialSuccess", fmt.Sprintf("%v", req.GetReturnPartialSuccess())) | ||
| } |
Contributor
There was a problem hiding this comment.
Do you know where these are coming from?
Author
There was a problem hiding this comment.
No. I didn't look at any of the generated code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.