This repository was archived by the owner on Nov 18, 2025. It is now read-only.
feat: use bazel build in docker #955
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-cla
bot
added
the
cla: yes
feywind
approved these changes
Aug 13, 2021
docker/Dockerfile
Outdated
| # Print versions for debugging purposes | ||
| RUN gapic-generator-typescript --version | ||
| RUN protoc --version | ||
| Run bazel --version |
Contributor
There was a problem hiding this comment.
Is this supposed to be RUN?
Collaborator
Author
There was a problem hiding this comment.
Good catch. Thanks for that.
alexander-fenster
suggested changes
Aug 13, 2021
docker/test.sh
Outdated
|
|
||
| # Run bazel use generator generating showcase client library | ||
| SHOWCASE_PROTOS=`pwd`/test-fixtures/protos/google/showcase/v1beta1 | ||
| bazel run //:gapic_generator_typescript -- -I $SHOWCASE_PROTOS --output_dir $DIR_NAME `find $SHOWCASE_PROTOS -name '*.proto'` |
Contributor
There was a problem hiding this comment.
Wait... This test script is supposed to execute docker run because this is a test of how Docker image works. We need to start using bazel in the Docker start script (entry point, start.sh).
summer-ji-eng
force-pushed
the
docker_bazel
branch
from
6fa5a79 to
169c1b4
Compare
summer-ji-eng
added
the
do not merge
|
Any updates on this? It's blocking the re-enablement of the TypeScript smoke test in Showcase (googleapis/gapic-showcase#915) |
Contributor
|
@vchudnov-g This is a good candidate for the upcoming fixit. |
Collaborator
Author
|
Need to re-investigate how to solve this. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bazel build to generate showcase client library in docker