chore(storage): Update for appendable uploads.#98
Open
cjc25 wants to merge 1 commit intogoogleapis:mainfrom
Open
chore(storage): Update for appendable uploads.#98cjc25 wants to merge 1 commit intogoogleapis:mainfrom
cjc25 wants to merge 1 commit intogoogleapis:mainfrom
Conversation
Go SDK contains several retry conformance tests for appendable uploads. Upstream the retry tests from there - they reflect scenarios which should be supported by any SDK. Note that the precise counts of bytes for non-idempotent operations reflect Go SDK defaults around how often to request a server-side flush. That may not apply in other SDKs or may require config to match. See googleapis#97
product-auto-label
bot
added
the
api: storage
tritone
reviewed
Nov 10, 2025
Contributor
tritone
left a comment
tritone
left a comment
There was a problem hiding this comment.
LGTM.
FYI @ShreyasSinha @bajajneha27 can you ensure that this will not cause tests to break for C++ & Java?
I can spin off issues to actually implement the appendable uploads tests specified here.
Author
|
Looks like the test fail is because the docker image uses go 1.22.11, but |
Collaborator
|
Java will not be broken if a merge happens here. It will need a release of the java-conformance-tests picking this up, but would then be a dependency bump PR and not block other things. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Go SDK contains several retry conformance tests for appendable uploads. Upstream the retry tests from there - they reflect scenarios which should be supported by any SDK.
Note that the precise counts of bytes for non-idempotent operations reflect Go SDK defaults around how often to request a server-side flush. That may not apply in other SDKs or may require config to match.
Fixes #97