Skip to content

fix: parsing of qualifiers with colons #153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mateusnr wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: parsing of qualifiers with colons #153

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions cbt.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2163,10 +2163,10 @@ func parseColumnsFilter(columns string) (bigtable.Filter, error) {
}

func columnFilter(column string) (bigtable.Filter, error) {
splitColumn := strings.Split(column, ":")
splitColumn := strings.SplitN(column, ":", 2)
if len(splitColumn) == 1 {
return bigtable.ColumnFilter(splitColumn[0]), nil
} else if len(splitColumn) == 2 {
} else {
if strings.HasSuffix(column, ":") {
return bigtable.FamilyFilter(splitColumn[0]), nil
} else if strings.HasPrefix(column, ":") {
Expand All @@ -2176,8 +2176,6 @@ func columnFilter(column string) (bigtable.Filter, error) {
qualifierFilter := bigtable.ColumnFilter(splitColumn[1])
return bigtable.ChainFilters(familyFilter, qualifierFilter), nil
}
} else {
return nil, fmt.Errorf("bad format for column %q", column)
}
}

Expand Down
8 changes: 4 additions & 4 deletions cbt_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -178,12 +178,12 @@ func TestParseColumnsFilter(t *testing.T) {
),
},
{
in: "familyA:columnA:cellA",
fail: true,
in: "familyA:columnA:text",
out: bigtable.ChainFilters(bigtable.FamilyFilter("familyA"), bigtable.ColumnFilter("columnA:text")),
},
{
in: "familyA::columnA",
fail: true,
in: "familyA::columnA",
out: bigtable.ChainFilters(bigtable.FamilyFilter("familyA"), bigtable.ColumnFilter(":columnA")),
},
}

Expand Down