Fix a shadow remote code execution #1404
Open
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The transformMarkdown function fails to recognize standalone Carriage Return (\r) characters as line terminators. When processing Markdown, it incorrectly wraps text containing \r into a single JavaScript comment. Node.js, however, treats \r as a valid line break, causing any code following the \r to be executed instead of remaining commented out. This allows arbitrary code execution hidden within plain text sections of Markdown files. The vulnerability exists because of a mismatch between the parser's logic and the JavaScript engine's (Node.js) specification.
Author
|
Since this involves unintended code execution via a parsing bypass, would you be open to opening a GitHub Security Advisory for this? |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes ##1403 / suggests an improvement
This was discovered during a security audit of zx. Although Google VRP determined it doesn't meet their internal severity threshold for a 'security bug' tracking, it remains a functional flaw that allows unintended code execution. This PR resolves the parsing discrepancy.