Refactor for Robustness: Fix Error Swallowing and Temp File Generation (#1394)

build/core.cjs

@@ -387,7 +387,7 @@ function formatCmd(cmd) {
     }
   }
   cap();
-  return out.replaceAll("\n", import_vendor_core.chalk.reset("\n> ")) + "\n";
+  return out.replace(/\n/g, import_vendor_core.chalk.reset("\n> ")) + "\n";
 }
 
 // src/core.ts

src/cli.ts

@@ -193,7 +193,9 @@ function linkNodeModules(cwd: string, external: string): string {
 function lstat(p: string) {
   try {
     return fs.lstatSync(p)
-  } catch {}
+  } catch (e) {
+    if ((e as NodeJS.ErrnoException).code !== 'ENOENT') throw e
+  }
 }
 
 async function readScript() {
@@ -279,10 +281,10 @@ export function normalizeExt(ext?: string): string | undefined {
 // prettier-ignore
 function getFilepath(cwd = '.', name = 'zx', _ext?: string): string {
   const ext = _ext || argv.ext || EXT
-  return [
-    name + ext,
-    name + '-' + randomId() + ext,
-  ]
-    .map(f => path.resolve(process.cwd(), cwd, f))
-    .find(f => !fs.existsSync(f))!
+  const basePath = path.resolve(process.cwd(), cwd, name)
+  let filepath = basePath + ext
+  while (fs.existsSync(filepath)) {
+    filepath = basePath + '-' + randomId() + ext
+  }
+  return filepath
 }

src/core.ts

@@ -1059,14 +1059,19 @@ export async function kill(
   for (const p of await ps.tree({ pid, recursive: true })) {
     try {
       process.kill(+p.pid, signal)
-    } catch (e) {}
+    } catch (e) {
+      // Ignore if process is already dead
+    }
   }
   try {
     process.kill(-pid, signal)
   } catch (e) {
+    // Ignore if process group is already dead
     try {
       process.kill(+pid, signal)
-    } catch (e) {}
+    } catch (e) {
+      // Ignore if process is already dead
+    }
   }
 }
 

src/log.ts

@@ -218,5 +218,5 @@ export function formatCmd(cmd: string): string {
     }
   }
   cap()
-  return out.replaceAll('\n', chalk.reset('\n> ')) + '\n'
+  return out.replace(/\n/g, chalk.reset('\n> ')) + '\n'
 }