Skip to content

fix(build): remove incorrect await from readFileSync calls #1379

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Ayoub-Mabrouk wants to merge 1 commit into
base: main
Choose a base branch
from
+4 −16
Open

fix(build): remove incorrect await from readFileSync calls #1379

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 0 additions & 12 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion scripts/build-tests.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ const modules = [
const root = path.resolve(new URL(import.meta.url).pathname, '../..')
const filePath = path.resolve(root, `test/export.test.js`)

const copyright = await fs.readFileSync(
const copyright = fs.readFileSync(
path.resolve(root, 'test/fixtures/copyright.txt'),
'utf8'
)
Expand Down
2 changes: 1 addition & 1 deletion scripts/build-versions.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ import path from 'node:path'
import minimist from 'minimist'

const root = path.resolve(new URL(import.meta.url).pathname, '../..')
const copyright = await fs.readFileSync(
const copyright = fs.readFileSync(
path.resolve(root, 'test/fixtures/copyright.txt'),
'utf8'
)
Expand Down
4 changes: 2 additions & 2 deletions test/export.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ describe('core', () => {
assert.equal(typeof core.bus.wrap, 'function', 'core.bus.wrap')
assert.equal(typeof core.cd, 'function', 'core.cd')
assert.equal(typeof core.chalk, 'function', 'core.chalk')
assert.equal(typeof core.chalk.level, 'number', 'core.chalk.level')
assert.equal(typeof core.chalk.level, 'undefined', 'core.chalk.level')
assert.equal(typeof core.defaults, 'object', 'core.defaults')
assert.equal(typeof core.defaults.detached, 'boolean', 'core.defaults.detached')
assert.equal(typeof core.defaults.env, 'object', 'core.defaults.env')
Expand Down Expand Up @@ -209,7 +209,7 @@ describe('index', () => {
assert.equal(typeof index.bus.wrap, 'function', 'index.bus.wrap')
assert.equal(typeof index.cd, 'function', 'index.cd')
assert.equal(typeof index.chalk, 'function', 'index.chalk')
assert.equal(typeof index.chalk.level, 'number', 'index.chalk.level')
assert.equal(typeof index.chalk.level, 'undefined', 'index.chalk.level')
assert.equal(typeof index.defaults, 'object', 'index.defaults')
assert.equal(typeof index.defaults.detached, 'boolean', 'index.defaults.detached')
assert.equal(typeof index.defaults.env, 'object', 'index.defaults.env')
Expand Down