Skip to content

Reduce allocations in ScriptsManager #108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dli7319 merged 1 commit into from
Dec 31, 2025
Merged

Reduce allocations in ScriptsManager #108

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 26 additions & 12 deletions src/core/components/ScriptsManager.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,10 @@ export class ScriptsManager {
/** The set of scripts currently being initialized. */
private initializingScripts = new Set<Script>();

private seenScripts = new Set<Script>();
private syncPromises: Promise<void>[] = [];
private checkScriptBound = this.checkScript.bind(this);

constructor(private initScriptFunction: (script: Script) => Promise<void>) {}

/**
Expand Down Expand Up @@ -53,29 +57,39 @@ export class ScriptsManager {
this.initializingScripts.delete(script);
}

/**
* Helper for scene traversal to avoid closure allocation.
*/
private checkScript(obj: THREE.Object3D) {
if ((obj as MaybeScript).isXRScript) {
const script = obj as Script;
this.syncPromises.push(this.initScript(script));
this.seenScripts.add(script);
}
}

/**
* Finds all scripts in the scene and initializes them or uninitailizes them.
* Returns a promise which resolves when all new scripts are finished
* initalizing.
* @param scene - The main scene which is used to find scripts.
*/
async syncScriptsWithScene(scene: THREE.Scene) {
const seenScripts = new Set<Script>();
const promises: Promise<void>[] = [];
scene.traverse((obj) => {
if ((obj as MaybeScript).isXRScript) {
const script = obj as Script;
promises.push(this.initScript(script));
seenScripts.add(script);
}
});
await Promise.allSettled(promises);
syncScriptsWithScene(
scene: THREE.Scene
): Promise<PromiseSettledResult<void>[]> {
this.seenScripts.clear();
this.syncPromises.length = 0;

scene.traverse(this.checkScriptBound);

// Delete missing scripts.
for (const script of this.scripts) {
if (!seenScripts.has(script)) {
if (!this.seenScripts.has(script)) {
this.uninitScript(script);
}
}

return Promise.allSettled(this.syncPromises);
}

callSelectStart(event: SelectEvent) {
Expand Down