Add a warning when using xarray_beam.ChunksToZarr with no template #112
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
copybara-service
bot
force-pushed
the
test_721163016
branch
3 times, most recently
from
9994df0 to
f1b0209
Compare
copybara-service
bot
changed the title
copybara-service
bot
force-pushed
the
test_721163016
branch
5 times, most recently
from
47acdb7 to
c521acc
Compare
If this works well at some point in the future (e.g., using zarr v3), we can always remove the warning. But for now, this is better than letting users run directly into the race condition in #85 I've also removed all suggestions from the docs of omitting a `template`. PiperOrigin-RevId: 728341864
copybara-service
bot
force-pushed
the
test_721163016
branch
from
c521acc to
a045e5f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a warning when using xarray_beam.ChunksToZarr with no template
If this works well at some point in the future (e.g., using zarr v3), we can always remove the warning. But for now, this is better than letting users run directly into the race condition in #85
I've also removed all suggestions from the docs of omitting a
template.