[xarray-beam] replace setup_executor with needs_setup in ChunksToZarr #110
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
copybara-service
bot
force-pushed
the
test_715610663
branch
from
3088178 to
f04a896
Compare
copybara-service
bot
changed the title
copybara-service
bot
force-pushed
the
test_715610663
branch
from
f04a896 to
29e698c
Compare
copybara-service
bot
force-pushed
the
test_715610663
branch
from
29e698c to
097536c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[xarray-beam] replace setup_executor with needs_setup in ChunksToZarr
If a user wants to manage setup themeslves, they can call
setup_zarr()ahead of time. That is cleaner than a fixed interface using a fire and forget concurrent.futures.Executor, which we cannot even check for success (because the future object gets thrown away).