Honor stderrthreshold when logtostderr is enabled#318
Open
pierluigilenoci wants to merge 2 commits intogoogle:masterfrom
Open
Honor stderrthreshold when logtostderr is enabled#318pierluigilenoci wants to merge 2 commits intogoogle:masterfrom
pierluigilenoci wants to merge 2 commits intogoogle:masterfrom
Conversation
After calling klog.InitFlags, opt into the fixed stderrthreshold behavior added in klog v2.140.0 so that severe-enough messages are still mirrored to stderr when logtostderr is set. Reference: kubernetes/klog#212 Signed-off-by: Pierluigi Lenoci <pierluigi.lenoci@gmail.com>
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Author
|
cc @tstromberg for review |
Author
|
@googlebot I signed it. |
Author
|
@googlebot I signed it. |
Signed-off-by: Pierluigi Lenoci <pierluigi.lenoci@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
klog.InitFlags, opt into the fixedstderrthresholdbehavior introduced in klog v2.140.0k8s.io/klog/v2from v2.0.0 to v2.140.0cmd/server/main.goandcmd/tester/main.goMotivation
When
logtostderris enabled (the default), klog historically suppressed thestderrthresholdflag, meaning thatWARNINGandERRORmessages could not be selectively filtered. klog v2.140.0 introduced new flags (legacy_stderr_threshold_behavior) to opt into the corrected behavior wherestderrthresholdis properly honored.Reference: kubernetes/klog#212
Test plan
stderrthresholdflag can be used to control which severity levels appear on stderr