Skip to content
This repository was archived by the owner on Jan 10, 2023. It is now read-only.

Fixed #270 #284

Open
BenjaminHolland wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fixed #270 #284

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 25 additions & 0 deletions assets/questions/reverseWords.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,14 @@ globalData.questions['reverseWords'] = { // eslint-disable-line dot-notation
auxiliaryCode: {
python:
`class AuxiliaryCode(object):
@classmethod
def reverseString(cls, s):
return str(s[::-1])

@classmethod
def reverseWordOrder(cls, s):
return s.split(' ')[::-1]

@classmethod
def forgetLastWord(cls, s):
result = ""
Expand Down Expand Up @@ -88,6 +96,23 @@ globalData.questions['reverseWords'] = { // eslint-disable-line dot-notation
"last reversed word."
].join('')
]
}, {
buggyFunctionName: 'AuxiliaryCode.reverseString',
messages: [
"Read the instructions closely. Did you overlook something important?",
Copy link
Contributor

@eyurko eyurko Apr 28, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tone here's a bit off -- try to mirror other questions' first buggy output message. This tells the learner that they have a bug, but comes across slightly condescending.

[
"It looks like you're reversing the entire string instead of each word. "
].join('')
]
}, {
buggyFunctionName: 'AuxiliaryCode.reverseWordOrder',
messages: [
"Are you sure you're interpreting the instructions correctly?",
Copy link
Contributor

@eyurko eyurko Apr 28, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same with this one. Generally it's best to provide an example that their code will fail on, in the hopes that they proactively fix their code after being presented with it.

Copy link
Contributor Author

@BenjaminHolland BenjaminHolland Apr 28, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The problem with that is it only works when the student understands the question. The first buggy error occurs because the student is attempting to solve the correct problem but is failing to implement the solution correctly.

Both these errors can be caused by the student is attempting to solve the wrong problem.
When this is the case, giving the student an example to work out on paper won't work. An example-solution pair works, but is already presented in the instructions.

While I agree that my tone isn't quite right, I'm struggling to find a good way to get the student to go back and look at the instructions more closely without directly stating that's what they should do, and without presenting the student with redundant information.

I think the ideal solution might actually be "flashing" the instruction box in some way rather than presenting a message, but we don't currently have the infrastructure. Adding callbacks for specific buggy answers might be a good thing overall.

Copy link
Contributor

@eyurko eyurko Apr 28, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mmm, that's a fair point, I agree. Getting the student to understand the question (if they don't already) requires some nuance. I think, though, that it might be worth doing -- "Check the instructions again. If you run your code on {{SAMPLE_INPUT}}, you return {{BUGGY_OUTPUT}}, not {{SAMPLE_OUTPUT}}.", in that case.

[
"It looks like you're reversing the order of the words instead of their ",
"contents. Is this what you were asked to do?"
Copy link
Contributor

@eyurko eyurko Apr 28, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd drop the final question of that sentence. It's usually enough to explain what the bug is to the learner.

].join('')
]
}],
performanceTests: []
}, {
Expand Down