docs(sqlcommenter_rails/README): update marginalia fork to modulitos#99
docs(sqlcommenter_rails/README): update marginalia fork to modulitos#99sjs994 merged 1 commit intogoogle:masterfrom
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). For more information, open the CLA check for this pull request. |
|
Thanks @modulitos, Looks good. We can merge this PR if you think basecamp/marginalia#130 will take long time. |
|
@sjs994 Thanks for the quick reply. In the meantime, I think it makes sense to merge in this PR. This will save new users from having to troubleshoot Rails 6 issues, and re-doing my efforts in rebasing the existing fork with the |
Thanks for the reply. Understandable on the timeline part. Will merge this PR. |
This PR updates the
sqlcommeter_railsreadme so that it references themodulitosfork instead of theglebmfork. Themodulitosfork makes the same changes as theglebmfork, except that it rebases the latest changes from themasterbranch of themarginaliarepo, so that we'll have support for Rails 6.For reference, here's the original commit where this README was originally updated:
70d62f0
Here's the PR to merge the
modulitosfork into themasterbranch ofmarginalia:basecamp/marginalia#130
I am working with the
marginaliamaintainers to get that PR merged in. When I do, I will update this README so that we can remove this extra step of using amarginaliafork :)Note:
Sorry about the duplicate PRs that I created earlier - I was having trouble getting the Google CLA checks to pass.