Skip to content

Conversation

@erikgeiser
Copy link
Contributor

@erikgeiser erikgeiser commented Nov 15, 2021

This PR closes #66 by adding support for zstd compression. It also allows users to optionally specify the compression level for gzip (gzip:-2 up to gzip:9) and zstd (zstd:default, zstd:fastest, zstd:better, zstd:best, zstd:17). It also contains a test for the compression configuration.

I can also add bzip2 such that this PR can supersede #67 if you want.

Copy link
Collaborator

@jarondl jarondl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for the contribution, along with good testing!

@erikgeiser
Copy link
Contributor Author

erikgeiser commented Nov 19, 2021

Thanks for your review. I fixed the issues. Should I also add bzip2 support such that this PR can supersede #67?

Copy link
Collaborator

@jarondl jarondl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, please add bzip2, seems simple enough to combine here.

@jarondl
Copy link
Collaborator

jarondl commented Nov 20, 2021

/gcbrun

@jarondl jarondl merged commit 186358d into google:master Nov 20, 2021
@erikgeiser
Copy link
Contributor Author

I took a look at bzip2 but I found that the library used in #67 seems like a stale repository where all commits are from 2015 and 2016 and no issue was ever closed. I also did not found a better library. I don't really want to take the responsibility of adding this stale dependency to this project.

Thank you for merging this PR, though!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support zstd compression (and optional compression levels)

2 participants