-
Notifications
You must be signed in to change notification settings - Fork 33
feat: zstd compression and compressor levels #68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: zstd compression and compressor levels #68
Conversation
jarondl
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much for the contribution, along with good testing!
|
Thanks for your review. I fixed the issues. Should I also add |
jarondl
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, please add bzip2, seems simple enough to combine here.
|
/gcbrun |
|
I took a look at Thank you for merging this PR, though! |
This PR closes #66 by adding support for
zstdcompression. It also allows users to optionally specify the compression level forgzip(gzip:-2up togzip:9) andzstd(zstd:default,zstd:fastest,zstd:better,zstd:best,zstd:17). It also contains a test for the compression configuration.I can also add
bzip2such that this PR can supersede #67 if you want.