Skip to content

Rename sharding_names to out_sharding in NNX Variable metadata #199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
copybara-service wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Rename sharding_names to out_sharding in NNX Variable metadata #199

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions qwix/_src/flax_util.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -389,12 +389,18 @@ def update_boxed(
if value is not None:
boxed = boxed.replace(value)
shape = boxed.value.shape
axes = boxed.get_metadata().get('sharding_names', None)
metadata = boxed.get_metadata()
# Check for out_sharding first (Flax >= 0.12.4), then sharding_names
if 'out_sharding' in metadata:
sharding_key = 'out_sharding'
else:
sharding_key = 'sharding_names'
axes = metadata.get(sharding_key, None)
if isinstance(axes, (list, tuple)):
axes = update_sharding(
axes, shape=shape, split=split, merge=merge, transpose=transpose
)
boxed.set_metadata(sharding_names=axes)
boxed.set_metadata(sharding_key, axes)
elif isinstance(boxed, jax.Array): # not boxed.
if value is not None:
boxed = value
Expand Down